Another Bug loading a game - build 8231

[Travis]

I'm sure you programming guys are over this, but I want to put this bug up before the next release, so everything is good.

First of all, I have 3 save games: 1 tides of darkness human campaign (level 12 campaign map), and 2 skirmish maps.

When I start stratagus in either debug or release mode, I cannot load the campaign map from the menu, nor can I load the first skirmish map save game. I can however load the second skirmish map save game, and after I loaded that one, I tried to load the campaign save and the other skirmish save, and they both loaded! I don't know what is causing this but I have an image capture of the callstack relating to this bug, so I supply that image here with every readout from the call stack so I hope it helps you guys.

I am using the latest build too.

[Joris Dauphin (joris-dauphin)]

Can you provide save game, thanks.

[Travis (dinky-dye-aussie)]

sure man - I knew I should've done this when I posted, oh well.

Anyways here they are.

savetest1.sav.gz it the only one that will load straight from the the main menu. the other two - game.sav.gz and campaign12exphuman.sav.gz will only load once savetest1.sav.gz has been loaded...it's weird but I hope you can sort it out.

[Joris Dauphin (joris-dauphin)]

It seems that some lua file are loaded more than once, and that the some redefinitions are not managed correctly.
In our current case, Construction stuff.
I have made some fix to avoid crash in action_built and to manage correctly redefinition of constructions.
But it seems that I don't fix all issues :-/.

[Joris Dauphin (joris-dauphin)]

Now, I have no crash :-)

But I have an issue with triggers that create a win condition when loading savetest1 from the others...

[Travis (dinky-dye-aussie)]

Thanks for looking into it. I'm compiling the latest revision now. I'll let you know what happens with the loadgames.

I did forget to mention that at one stage the "campaign12exphuman.sav.gz" did load fine, but when I went to explore an area of the map with my gnomish flying machine, I came accross an orc destroyer which as soon as it started to head towards my flying machine, caused a crash. I don't know if that corrupted the save game files or what.

But that was before. I will try and load these saves again and see what happens.

[Travis (dinky-dye-aussie)]

hmmm, I got the victory condition with the game.sav.gz savegame...but the campaign save and savetest1 loaded no worries :-)

I'll keep testing though to make sure it all runs smooth as, I want this load/save bug stuff sorted before 2.2.7 is out.

[Joris Dauphin (joris-dauphin)]

Revision 8236 fix the winning condition victory.
We need to have a cleaner way to manage Lua Variable

The crash seems to be related to a vision bug when Loading/Saving.

[Travis (dinky-dye-aussie)]

Nice work man! I tried loading all 3 of the save games, and all 3 loaded successfully! I exited and restarted after each load test though, just to make the test thorough and to see if all games loaded from the main menu, and they do, so I'm so thankful to you for getting it working :-)

[Joris Dauphin (joris-dauphin)]

So, I close the bug
Create a new bug for the crash with the Flying machine (with easy steps to reproduce :-) ).