TPac: Hide place hold links for non-holdable bibs

Bug #985895 reported by Thomas Berezansky
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Wishlist
Unassigned

Bug Description

The branch below hides search result and record summary title level place hold links when there are no holdable copies on the bib in TPac. This is based on the copy, status, and location holdable flags. Note that this doesn't mean no visible holdable copies, all copies can be opac invisible, but if any are holdable copies the links still show up.

EXCEPTION: When you are in the staff client and have the PLACE_UNFILLABLE_HOLD permission the place hold links show up anyway.

It contains some extra code for metarecords that I didn't find any place to hook up, and API calls from a previous iteration of the checks that I thought might be useful to keep around.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/tsbere/tpac_holdable_check

Tags: pullrequest
Changed in evergreen:
milestone: none → 2.3.0-alpha2
Changed in evergreen:
milestone: 2.3.0-alpha2 → 2.3.0-beta1
Revision history for this message
Dan Scott (denials) wrote :

Thanks to assistance from Thomas, I was able to merge the efforts of Art Rhyno with Thomas' efforts in this branch to also offer per-skin control over hiding place hold links in the additional situation where libraries don't want to allow holds on available items. See bug # 1031789, for additional details. The combined efforts have been committed to master.

Changed in evergreen:
status: New → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.