Lcms2 enabled build reports malfunctioning color management

[Vladimir Savic]

In Inkscape Preferences dialog, and below Color Management label, "Note: Color management has been disabled in this build" message appears. After su-v's suggestion I've executed "grep LCMS config.h" in terminal with "#define HAVE_LIBLCMS2 1" message as a result.

Furthermore, even though message itself is misleading, color management for document is possible turning on, but not off again. Both ruler corner button and View menu item are disabled.

Ubuntu 12.04 (a few days before release) on amd64 hardware.

[su_v (suv-lp)]

@Jon - assigning to you: could you recheck the 'if' condition as discussed on irc?
<http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/view/head:/src/ui/dialog/inkscape-preferences.cpp#L854>

(Issue confirmed by ScislaC on irc)

[ScislaC (scislac)]

The second part of this report is still a problem. The "Color-managed view" option in the view menu & the corresponding widget where the rulers meet still only toggle and then are disabled after another attempt to toggle when built against lcms2.

[su_v (suv-lp)]

> In Inkscape Preferences dialog, and below Color Management label, "Note:
> Color management has been disabled in this build" message appears.

Reproduced on Ubuntu 12.10 (64bit, VM) with
- inkscape 0.48.3.1 (0.48.3.1-1ubuntu6)
- liblcms2-2 (Version: 2.2+git20110628-2ubuntu4)

Revision to be backported to 0.48.x (if feasible):
<http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/11277>

[su_v (suv-lp)]

ScislaC wrote:
> The second part of this report is still a problem. The "Color-managed
> view" option in the view menu & the corresponding widget where the
> rulers meet still only toggle and then are disabled after another
> attempt to toggle when built against lcms2.

In my tests on Ubuntu 12.10, Unity's global menu doesn't properly sync the menu item status with the status of the toggle button - i.e. not reproduced if running Inkscape without unity support:
$ UBUNTU_MENUPROXY=0 LIBOVERLAY_SCROLLBAR=0 inkscape

[su_v (suv-lp)]

Clarification:
> In my tests on Ubuntu 12.10, Unity's global menu (…)

That's testing with current trunk build (r11891).

[su_v (suv-lp)]

Attaching diff for changes from r11277 backported for branch 0.48.x

Could someone with a local 0.48.x branch on a system which has lcms2 installed test the diff?

[ScislaC (scislac)]

seems okay here

[su_v (suv-lp)]

> seems okay here

It seems to have no unintended side-effects with builds using LCMS1 either (OS X) - do we need to have a test build on Windows too, before committing to the branch?

[ScislaC (scislac)]

backported to 0.48.x r9938

[ScislaC (scislac)]

Stupid overlap of comments... it shouldn't cause any issues, but if anyone wants to do a test win32 build with the current branch revision I wouldn't be opposed to it. :)

[jazzynico (jazzynico)]

Well, as far as I can see from the devlibs, win32 builds still use lcms1 (1.17).

[su_v (suv-lp)]

@ScislaC - can you confirm on Ubuntu that the remaining issue is related to Ubuntu's global menu? If so, wouldn't it be better to move it to a separate report (tagged 'ui'), and close this one as 'Fix Released'?

[ScislaC (scislac)]

The main issue actually reported here was indeed included in 0.48.4. The preferences dialog now reports correctly.

As for the remaining issue, yes it should be moved to a new report. I won't be able to test if it's a global menu issue until later.