ThreadsafeForwardingResult leaks tags
Bug #985613 reported by
Jonathan Lange
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
testtools |
Fix Released
|
Critical
|
Jonathan Lange |
Bug Description
tags set in one test are local to that test. Tests that follow should know nothing about tags set in previous tests. However, once a test-local tag is set in ThreadsafeForwa
tsfr = ThreadsafeForwa
tsfr.startTest(a)
tsfr.tags(x, y)
tsfr.
tsfr.stopTest(a)
tsfr.startTest(b)
tsfr.
tsfr.stopTest(b)
And 'result' receives:
startTest(a)
tags(x, y)
addSuccess(a)
stopTest(a)
startTest(b)
tags(x, y)
addSuccess(b)
stopTest(b)
Whereas it should receive:
startTest(a)
tags(x, y)
addSuccess(a)
stopTest(a)
startTest(b)
addSuccess(b)
stopTest(b)
Related branches
lp:~jml/testtools/tag-leakage
- Jonathan Lange: Approve
-
Diff: 60 lines (+32/-0)2 files modifiedtesttools/testresult/real.py (+1/-0)
testtools/tests/test_testresult.py (+31/-0)
Changed in testtools: | |
assignee: | nobody → Jonathan Lange (jml) |
Changed in testtools: | |
status: | In Progress → Fix Committed |
Changed in testtools: | |
milestone: | none → next |
status: | Fix Committed → Fix Released |
To post a comment you must log in.