widelands

Improve OpenBSD support

Bug #983448 reported by Anthony J. Bentley on 2012-04-16

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	widelands	Fix Released	Medium	Unassigned	widelands build18-rc1

Bug Description

Here is a patch (as of build17-rc2) that fixes some issues on OpenBSD:

- needs to be linked with execinfo
- <ctype.h> #defines _C to be 20, which conflicts with some templates
- nitems() conflicts with a macro definition in the system
- OpenBSD doesn't have O_NOATIME
- due to namespace issues <sys/types.h> must be #included before <sys/socket.h>
- default to x11 driver

Revision history for this message

Anthony J. Bentley (anthonyjbentley) wrote on 2012-04-16:

Patch that fixes build issues on OpenBSD Edit (9.7 KiB, text/plain)

Revision history for this message

SirVer (sirver) wrote on 2012-04-17: Re: [Bug 983448] Re: Improve OpenBSD support

Thanks. Will be merged after b17

  status triaged
  importance medium
  milestone build18-rc1

Changed in widelands:
importance:	Undecided → Medium
milestone:	none → build18-rc1
status:	New → Triaged

Revision history for this message

Hans Joachim Desserud (hjd) wrote on 2012-04-17:

Hi Anthony, welcome to Launchpad. (And thanks for your patch)

Note that Debian/kFreeBSD (Debian with the FreeBSD kernel instead of Linux) also had some problems with execinfo. Might be general *BSD issues?

According to the changelog of widelands_17~rc2-3:
"on kfreebsd, the execinfo library cannot be found for an unkown reason.
Try to survive this fact to fix the resulting FTBFS."

See http://packages.debian.org/changelogs/pool/main/w/widelands/widelands_17~rc2-3/changelog and http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=668670 for more info.