libdrizzle version not a string in pkg file in 7.1
Bug #982755 reported by
Brian Aker
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Drizzle |
Fix Released
|
Low
|
Brian Aker |
Bug Description
Version information is off in PKG file, additionally the include directory is wrong in the libdrizzle-1.0 file.
Related branches
lp:~brianaker/drizzle/982799
- Drizzle Trunk: Pending requested
-
Diff: 280 lines (+113/-33)11 files modifiedMakefile.am (+1/-0)
configure.ac (+2/-20)
drizzled/drizzled.cc (+31/-7)
libdrizzle-1.0/drizzle_client.h (+1/-0)
libdrizzle-1.0/include.am (+1/-0)
libdrizzle-1.0/version.h.in (+41/-0)
libdrizzle/drizzle.cc (+1/-1)
m4/libdrizzle_version.m4 (+30/-0)
support-files/drizzle.pc.in (+1/-1)
support-files/libdrizzle-1.0.pc.in (+2/-2)
support-files/libdrizzle.pc.in (+2/-2)
Changed in drizzle: | |
assignee: | nobody → Brian Aker (brianaker) |
milestone: | none → 7.1.34 |
importance: | Undecided → Low |
status: | New → In Progress |
Changed in drizzle: | |
status: | In Progress → Fix Released |
To post a comment you must log in.
Ah, I see what you mean now. Nothing like a patch to explain what cannot be expressed in words...
I'm not convinced about one change:
200 const char *drizzle_ version( void) VERSION_ STRING;
201 {
202 - return PACKAGE_VERSION;
203 + return LIBDRIZZLE_
204 }
This is what I get when doing "drizzle --version" right? I would expect that to match the PACKAGE_VERSION. I.e. the end user has installed some drizzle- server- 7.1.33. ..rpm and drizzle- client- 7.1.33. ..rpm and he would expect those numbers to match.
Each drizzle client binary is then statically linked to some version of the libdrizzle library, but this is not what the end user primarily expects to see. (If you want, you could add a new option: "drizzle --libdrizzle- version"