bad sync server still saves the preference
Affects | Status | Importance | Assigned to | Milestone | ||
---|---|---|---|---|---|---|
Tomdroid | Status tracked in Stable | |||||
Beta |
Fix Released
|
Low
|
Unassigned | |||
Stable |
Fix Released
|
Medium
|
Unassigned |
Bug Description
If you enter a wrong sync server, you get an error message (after having merged lp:~tomdroid-dev/tomdroid/rework-auth-error-handling of course) but the preference is still saved.
I tried fixing it quickly but couldn't do so in satisfying way.
We can't simply prevent the preference update because we are running things in another thread and I couldn't figure out how to have the onPreferenceCha
I also considered resetting the old value after receiving a failure but there's all sort of race conditions where the user's URL would be overwritten and it's just sloppy in my mind..
The real fix, which is intrusive enough to be done later and not in the 0.5.1 (or whatever we'll call it) cycle, is to get the OAUTH stuff done in it's own activity, pretty much like this guy do: https:/
So, registering the bug because it exist. Anyone interested in implementing the fix: knock yourselves out! and let us know you are working on it.
Changed in tomdroid: | |
status: | New → Confirmed |
Changed in tomdroid: | |
milestone: | none → 0.7.3 |
assignee: | nobody → Stefan Hammer (j-4) |
status: | Confirmed → Fix Committed |
Changed in tomdroid: | |
status: | Fix Committed → Fix Released |
Is this still needed?
Do we still plan to merge lp:~tomdroid-dev/tomdroid/rework-auth-error-handling, or do we need a new solution?