Object context menu (right-click) acts on bottom-most instead of top-most object under cursor position

Bug #979567 reported by su_v
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Inkscape
Fix Released
Medium
John Smith

Bug Description

Regression in current trunk:
Object context menu (right-click) acts on bottom-most instead of top-most object under cursor position

Steps to reproduce:
1) open attached sample file
2) right-click on each of the text objects and compare the context menu entries

Expected result:
Same context menu with text-specific entries for each of the text objects (top-most object at current position)

Actual result:
Context menu specific to bottom-most (unlocked) object is opened on RMB click

Workaround:
1) select text object (LBM click)
2) open context menu with 'Shift+F10' (without RMB click)

On Mac OS X 10.5.8. (32bit) and OS X 10.7.2 (64bit):
- not reproduced with Inkscape 0.46, 0.47, 0.48.x and 0.48+devel <= r10577
- reproduced with Inkscape 0.48+devel >= r10581
The regression was possibly introduced with the merge of the rendering cache branch in revision 10579.

This is a follow-up report to:
Bug #962002 <image> context menu item 'Edit externally…' ignores current selection
The correct fix for bug #962002 is probably to make the right-click context menu work on the top-most selectable object under the current pointer position again.

(See also <http://article.gmane.org/gmane.comp.graphics.inkscape.devel/6897> - though I'm not sure how relevant this paper actually was for the implementation of the context menu)

Revision history for this message
su_v (suv-lp) wrote :
tags: added: regression
jazzynico (jazzynico)
Changed in inkscape:
importance: Undecided → Medium
status: New → Confirmed
su_v (suv-lp)
Changed in inkscape:
milestone: none → 0.49
Revision history for this message
jazzynico (jazzynico) wrote :

This one is very annoying to me...

Changed in inkscape:
status: Confirmed → Triaged
Revision history for this message
su_v (suv-lp) wrote :

JazzyNico wrote:
> This one is very annoying to me...

Agreed. I stopped using the context menu in current trunk altogether (this is most unfortunate for images, because their specific context menu entries (image properties, edit externally) aren't available elsewhere nor as keyboard shortcuts).

IMHO this is a blocker for 0.49 (feel free to remove the tag again if you don't agree).

tags: added: blocker
Revision history for this message
John Smith (john-smithi) wrote :

Patch attached that should fix this.
It uses the same logic as the left click to determine the top z-order item.

Changed in inkscape:
assignee: nobody → John Smith (john-smithi)
status: Triaged → In Progress
Revision history for this message
John Smith (john-smithi) wrote :

Fix committed as r11672.

Changed in inkscape:
status: In Progress → Fix Committed
Revision history for this message
su_v (suv-lp) wrote :

@John - many thanks for the fix! :)

Changed in inkscape:
milestone: 0.49 → none
status: Fix Committed → Fix Released
tags: removed: blocker
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.