jspac basic search loses limiters

[Jason Stephenson]

Evergreen Version: 2.2.0-mvlc-3 (master as of 20120408 + mvlc modifications)
or 2.2.0 beta2 (basically)
Opensrf: 2.1.0alpha
PG version: 9.1.3
Server OS: Ubuntu 10.04.3 (also seen on 12.04 daily build) not o/s specific bug.

This looks like an undesired result of fixing https://bugs.launchpad.net/evergreen/+bug/788629

One of our member's staff reported this:

Patrons and our staff are finding that after the Sunday update, the search options do not remain set after implementing a search. Many patrons have brought this to our attention voicing frustration that after selecting for example "Title" and "Music" that after 1 lookup they need to reselect the options. This is also the case in the staff client.

After further investigation, it turns out to be more like:

Input: Basic Search results with title/format restriction
Results: Title and Location setting information is retained. Format setting resets

Input: Retaining results, clicking on "Advanced Search:
Results: All retained information is transferred correctly

Input: using retained results and selecting an "item type" filter
Result: Item type is retained in the search result

Input: Refreshing / rerunning identical search
Result: Item Type filter is retained

Additionally, I have seen where if Advanced Search limits on a different type, and then the type is changed and the search re-run, from Movies & TV to Large Print, for instance. The search is run and showing results for Large Print, but the type drop down resets to Movies & TV.

Summary: It appears that the fix for the above bug is over zealous in maintaining advanced search format limiters and prevents basic search format limiters from sticking around.

[Jason Stephenson (jstephenson)]

Looks like the real issue is that basic and advanced search use item form and and item type differently.

Advanced search uses item type and basic/homesearch uses item form to mean what advanced search calls item type.

[Jason Stephenson (jstephenson)]

Oh, and don't think that because I reported this, that I have *any clue* how to fix it. I get lost in JSPAC.

[Jason Stephenson (jstephenson)]

A patron reported this to the evergreen feedback address:

I'm sorry if this is not the right place to send an observation
regarding use of the interface; however, it appears a recent change
has made
the interface not as user friendly. I'm using Evergreen at the
Merrimack Valley Library Consortium and noticed that the pulldown menu
at
the top right isn't 'sticky' anymore - I select an option from
[keyword,title,author,subject,series] and it stays as that selection
until I change
it after retrieving the results (sticky), but the [Formats] option
reverts back to All Formats after EVERY retrieval (not sticky). If
possible please
return it to it's previous functionality as this is much more usable.
I often revise search criteria etc, but stay within the same format
selection
and now have to touch that pull-down every time.

Thank you for making a great interface for interacting with our
library catalogs.

[Jason Stephenson (jstephenson)]

The following commit causes the above problem:

f4602609ff15772b4e18a23d4cf7b42e8a1689d8

The above commit was added to address the issue in https://bugs.launchpad.net/evergreen/+bug/788629

My suggestion is that the commit above be reverted, LP 788629 be set back to NEW or CONFIRMED, and a new solution worked out for LP 788629.

[Jason Stephenson (jstephenson)]

I am inclined to suggest that the original bug be marked won't fix, since it affects JSPAC and our focus should be on TPAC.