migration_get_all_unconfirmed() should use lower case "finished"

Bug #977719 reported by Mandar Vaze
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Mandar Vaze

Bug Description

Scenario :

nova/compute/manager.py : _finish_resize() updates the status is lower case
self.db.migration_update(context, migration_ref.id, {'status': 'finished'})

db/sqlalchemy/api.py : migration_get_all_unconfirmed() does :
    filter_by(status="FINISHED")

Expected behavior :

migration_get_all_unconfirmed() should also use lower case "finished"

Branch: master
git commit nova : 384b758166ed72fc16da7c5ad18eedc044bbc633

Tags: ntt
Mandar Vaze (mandarvaze)
Changed in nova:
assignee: nobody → Mandar Vaze (mandarvaze)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/6402

Changed in nova:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/6402
Committed: http://github.com/openstack/nova/commit/63c59b877513a02ee94e29978314971734148de0
Submitter: Jenkins
Branch: master

commit 63c59b877513a02ee94e29978314971734148de0
Author: Mandar Vaze <email address hidden>
Date: Tue Apr 10 05:05:17 2012 -0700

    migration_get_all_unconfirmed() now uses lowercase "finished" Fixes bug
    977719

    status set in _finish_resize is lower case, but
    migration_get_all_unconfirmed() was filtering using FINISHED
    Also updated corresponding test case to use lower case "finished"
    Updated Authors file

    Change-Id: Ia30e66e541bba91a9dd3d3af1429b2312870793a

Changed in nova:
status: In Progress → Fix Committed
Devin Carlen (devcamcar)
Changed in nova:
milestone: none → folsom-2
milestone: folsom-2 → folsom-1
importance: Undecided → Low
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: folsom-1 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.