Standing penalty CAPTURE and FULFILL blocks

Bug #977465 reported by Bill Erickson
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Undecided
Unassigned
2.3
Fix Released
Undecided
Unassigned

Bug Description

The goal of this feature is to add two additional types of standing penalty blocks to manage holds. The existing "HOLD" block prevents new holds from being created. I'd like to propose we add "CAPTURE" and "FULFILL" blocks as well for finer grained control.

When a user has a standing penalty containing "CAPTURE" in the block list, the user can place holds (pending no HOLD block), but no holds for the user will be captured. This is effectively a policy-based freeze of the hold.

Users that have penalties with "FULFILL" in the block list will be able to place holds and have their holds captured (i.e. delivered) but will not be able to check out the captured holds. This is basically a honey pot for getting patrons in to pay outstanding balances.

As part of the development, any penalty that currently has a HOLD block would also get the CAPTURE and FULFILL blocks added for backwards compatibility.

Branch to follow.

Revision history for this message
Bill Erickson (berick) wrote :

Note to self: Add filter to the hold pull list generator to avoid listing copies for holds where the user currently has a CAPTURE block. Otherwise, staff will be pulling copies that can't be captured.

Revision history for this message
Bill Erickson (berick) wrote :

Code pushed to working => user/berick/hold-cap-fill-penalty-blocks

tags: added: pullrequest
Revision history for this message
Bill Erickson (berick) wrote :

Note that the code (IDL view) in bug #971989 will need to be updated to match these changes after either of these has been merged.

Revision history for this message
Bill Erickson (berick) wrote :

Force-pushed a rebased branch to resolve a master merge conflict.

Revision history for this message
Bill Erickson (berick) wrote :

Pushed:

    Apply HOLD block on new holds, CAPTURE block on existing

    With the addition of the CAPTURE block, the HOLD block should only apply
    for newly placed holds in the hold permit test
    (action.hold_request_permit_test).

Also merged in master.

Revision history for this message
Jason Stephenson (jstephenson) wrote :

Our members are interested in such a feature, so I'll give this one a test.

Revision history for this message
Jason Stephenson (jstephenson) wrote :

Signed off on the 9 commits in working/collab/dyrcona/hold-cap-fill-penalty-blocks.

It works for me and doesn't seem to break existing HOLD blocks or fulfilling holds normally.

Thanks Bill & Mike.

tags: added: signedoff
Revision history for this message
Mike Rylander (mrylander) wrote :

Thanks muchly. Merged to master!

Changed in evergreen:
status: New → Fix Committed
Ben Shum (bshum)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.