Inconsistent display of Patron Search screen

[Angela Kilsdonk]

Evergreen 2.1.1

Clicking on “Search for Patron by Name” on the default/portal screen in the staff client results in a vertical display of the Patron Search screen, even if the Library Setting: “Patron circulation summary is horizontal” is set to True. The display of this screen should be consistent throughout the staff client.

[Ben Shum (bshum)]

Confirmed, we noticed this during our testing but didn't get to finish figuring out the problem. We took the "easy" way out and just removed that option from the portal page in our production build.

[Jason Etheridge (phasefx)]

> Confirmed, we noticed this during our testing but didn't get to finish
> figuring out the problem.  We took the "easy" way out and just removed
> that option from the portal page in our production build.

It's probably using xulG.new_tab/xulG.set_tab instead of
xulG.new_patron_tab/xulG.set_patron_tab.

The patron tab functions don't take the first URL param from the
regular _tab functions.

[Thomas Berezansky (tsbere)]

The find_patron function in the portal page loads the vertical interface without checking the setting. It would need to be updated to check the setting and load the horizontal one where appropriate.

For a "you use only the horizontal one" quick-fix you could quickly hack in "use just the horizontal version" into that function, at least until someone makes it check the setting.

[Jason Etheridge (phasefx)]

collab/phasefx/portal_patron_search @ working/Evergreen.git
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/phasefx/portal_patron_search

Based off master but should be suitable for 2.1 as well

[Dan Scott (denials)]

Confirmed that Jason's branch fixes what it said it would fix, signed off and pushed to master, rel_2_2, and rel_2_1.

Also experienced the horizontal patron display for the first time.... interesting.

Thanks Jason!