'approved' rule should not modify the message

[Barry Warsaw]

In Mailman 3, technically rules should not have side effects. The 'approved' rule breaks this because it removes the Approved header (and other supported headers) from the message. There should instead be a handler that does the header cleaning, and the rule should not do this.

From an implementation standpoint, the same code can be used in both the handler and in the rule. You can use a slightly different API wrapper and use a flag to indicate whether the header should be removed or not. OTOH, some clever refactoring might make better sense.

[David Soto (david-soto)]

As far as I see, the cleanse handler removes the approved headers, too. I.e. whenever the message goes through the posting pipeline, the headers are removed.
Should they get removed when the message goes through other pipelines, too? If not, I guess the removal code from the approved rule could just be deleted?

[Abhilash Raj (raj-abhilash1)]

This bug has been moved to the new gitlab repo here: https://gitlab.com/mailman/mailman/issues/37