Nunit 2.6 Gui Showing wrong result state
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
NUnit V2 |
Fix Released
|
Critical
|
Charlie Poole |
Bug Description
I was using NUnit Version 2.5.2 dll for our customised nunit test application. Then It was showing proper reusult status in TestSuiteTreeVi
When I tried to find out the root cause of this issue ,then I comes to know in TestSuiteTreeNode class under Nunit.UiKit namespace ,there is one method CalcImageIndex.This method is changed following code .In version 2.6 it is as follow
private int CalcImageIndex()
{
if (this.result == null)
{
{
}
}
else
{
{
}
}
}
In Version 2.5.2 it is as follow
private int CalcImageIndex()
{
if (this.result == null)
{
{
}
}
else
{
{
}
}
}
If you see case ResultState.Success ,you will get the differnce. Why the failure case check is removed in that case?
Related branches
Changed in nunitv2: | |
status: | New → Triaged |
importance: | Undecided → Critical |
assignee: | nobody → Charlie Poole (charlie.poole) |
Changed in nunitv2: | |
milestone: | none → 2.6.1 |
Changed in nunitv2: | |
status: | Fix Committed → Fix Released |
Actually, both the old and the new code are wrong!
The old code is sensitive to the ordering of ignored and failed tests and will return an index based on whichever one is found first. Actually, we want failure to take precedence: