goby-moos fails to build on Mac OS X 10.7.2 with Google Protobuf 2.3.0

Bug #971971 reported by toby schneider
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Goby
Fix Released
Wishlist
Unassigned

Bug Description

Using Google Protocol Buffers 2.3.0, Goby 2.0 fails to build. See attached.

Related branches

Revision history for this message
toby schneider (tes) wrote :
Revision history for this message
toby schneider (tes) wrote :

It seems that in Google Protocol Buffers 2.3.0, the copy-constructor for RepeatedPtrField is private using the macro GOOGLE_DISALLOW_EVIL_CONSTRUCTORS. However, the Goby code compiles correctly in Ubuntu 10.04 using the same version of Protobuf, suggesting that only the Mac OS X version of g++ is using the copy-constructor for this code.

I suggest upgrading Google Protocol Buffers, as newer versions explicitly define this copy-constructor as public:
https://developers.google.com/protocol-buffers/docs/reference/cpp/google.protobuf.repeated_field#RepeatedPtrField

Changed in goby:
status: New → Triaged
toby schneider (tes)
Changed in goby:
status: Triaged → Fix Committed
toby schneider (tes)
Changed in goby:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.