glmark2 is not tracking tip

[Zach Pfeffer]

We're still tracking an old glmark2 branch, we need to switch to master as per:

On Wed, Feb 29, 2012 at 09:19:26AM -0600, Zach Pfeffer wrote:
> Alexandros,
>
> Can we switch back to your tip? For reference, whats the git, branch
> combo we should be tracking?

Hi Zach,

feel free to switch back to the tip any time you like. If you plan to use
this for demo purposes, just make sure to use the new "command-line"
interface, as described in a previous email (~Feb 22).

You should use the 'master' branch from:

git://git.linaro.org/people/afrantzis/glmark2.git

Thanks,
Alexandros

[Zach Pfeffer (pfefferz)]

Alexandros,

I'm getting the following errors when I build glmark2 on master:

In file included from frameworks/base/native/include/android/native_window.h:21:0,
from frameworks/base/opengl/include/EGL/eglplatform.h:83,
from frameworks/base/opengl/include/EGL/egl.h:36,
from packages/apps/glmark2/android/jni/src/canvas-android.cpp:27:
system/core/include/system/window.h:84:10: error: unused parameter 'id' [-Werror=unused-parameter]
system/core/include/system/window.h:87:10: error: unused parameter 'id' [-Werror=unused-parameter]
system/core/include/system/window.h:312:10: error: unused parameter 'id' [-Werror=unused-parameter]
system/core/include/system/window.h:315:10: error: unused parameter 'id' [-Werror=unused-parameter]
system/core/include/system/window.h:472:19: error: unused parameter 'window' [-Werror=unused-parameter]
system/core/include/system/window.h:472:19: error: unused parameter 'api' [-Werror=unused-parameter]
system/core/include/system/window.h:478:19: error: unused parameter 'window' [-Werror=unused-parameter]
system/core/include/system/window.h:478:19: error: unused parameter 'api' [-Werror=unused-parameter]
cp out/target/product/pandaboard/obj/SHARED_LIBRARIES/libglmark2-android_intermediates/src/scene-bump.d out/target/product/pandaboard/obj/SHARED_LIBRARIES/libglmark2-android_intermediates/src/scene-bump.P; sed -e 's/#.*//' -e 's/^[^:]*: *//' -e 's/ *\\$//' -e '/^$/ d' -e 's/$/ :/' < out/target/product/pandaboard/obj/SHARED_LIBRARIES/libglmark2-android_intermediates/src/scene-bump.d >> out/target/product/pandaboard/obj/SHARED_LIBRARIES/libglmark2-android_intermediates/src/scene-bump.P; rm -f out/target/product/pandaboard/obj/SHARED_LIBRARIES/libglmark2-android_intermediates/src/scene-bump.d
cc1plus: all warnings being treated as errors
make: *** [out/target/product/pandaboard/obj/SHARED_LIBRARIES/libglmark2-android_intermediates/src/canvas-android.o] Error 1
make: *** Waiting for unfinished jobs....

Here's the test build:

https://android-build.linaro.org/builds/~pfefferz/tipglmark2/

I'm compiling with the last Toolchain release:

TOOLCHAIN_URL=http://snapshots.linaro.org/android/~linaro-android/toolchain-4.6-2012.03/2/android-toolchain-eabi-linaro-4.6-2012.03-2-2012-03-15_12-39-18-linux-x86.tar.bz2

Would you mind taking a look?

[Zach Pfeffer (pfefferz)]

On Mon, Apr 02, 2012 at 08:44:43PM -0500, Zach Pfeffer wrote:
> On 7 March 2012 13:05, Alexandros Frantzis
> <email address hidden> wrote:
> > On Wed, Feb 29, 2012 at 09:19:26AM -0600, Zach Pfeffer wrote:
> >> Alexandros,
> >>
> >> Can we switch back to your tip? For reference, whats the git, branch
> >> combo we should be tracking?
> >
> > Hi Zach,
> >
> > feel free to switch back to the tip any time you like. If you plan to use
> > this for demo purposes, just make sure to use the new "command-line"
> > interface, as described in a previous email (~Feb 22).
> >
> > You should use the 'master' branch from:
> >
> > git://git.linaro.org/people/afrantzis/glmark2.git
> >
> > Thanks,
> > Alexandros
>
> Alexandros,
>
> I'm getting the following errors when I build glmark2 on master:
>
> In file included from
> frameworks/base/native/include/android/native_window.h:21:0,
> from frameworks/base/opengl/include/EGL/eglplatform.h:83,
> from frameworks/base/opengl/include/EGL/egl.h:36,
> from packages/apps/glmark2/android/jni/src/canvas-android.cpp:27:
> system/core/include/system/window.h:84:10: error: unused parameter
> 'id' [-Werror=unused-parameter]
<snip>
> Would you mind taking a look?
>

We use strict compilation flags when building glmark2 (-Wall -Wextra
-Werror). It seems that some AOSP header files have code with unused
parameters and break the build.

I have pushed a new revision to trunk which uses
-Wno-error=unused-parameter. Please try it out and let me know how it
goes. Perhaps we will need to tune the errors a bit more if we get
additional issues.

Thanks,
Alexandros

[Zach Pfeffer (pfefferz)]

http://review.android.git.linaro.org/#change,1771

[Zach Pfeffer (pfefferz)]

Fixed in all 12.05 builds.