Apply atmosphere effect only on bodies with atmosphere

[Mykyta Sytyi]

When you are changing location from ViewDialog window, you can appear on a body (i.e. Moon) and watch the atmosphere effect.

[Mykyta Sytyi (nsytyi)]

This will solve that problem

[treaves (treaves)]

In trunk, this button does work, even when switching landscape.

[treaves (treaves)]

I looked at your patch; atmosphere & fog are two different effects.

[Mykyta Sytyi (nsytyi)]

but, i.e. when changing your position to Moon, you will be situated on the moon and see atmosphere

[Alexander Wolf (alexwolf)]

You need change patch because atmosphere and fog are different effects. Question about enabling atmosphere effect need solve by type of solar system objects.

[treaves (treaves)]

O.K., it seems I did not understand what you were trying to accomplish. Yes, what Alex said.

If your intention to insure that the effects like fog & atmosphere only apply on bodies where they would - well, apply, I agree with that. But the patch does not accomplish that. It should be too difficult to factor in the observing location to your patch.

I'll mark this defect is new, but, please update the title; maybe something like: 'apply atmospheric effects only on bodies with atmospheres'?

[Mykyta Sytyi (nsytyi)]

OK, updated title and description.

And what schould be the "Fog" effect? Currently I can not see any visible changes, and I haven't found any effects using fog in the source code.

[treaves (treaves)]

Have a look at
http://bazaar.launchpad.net/~stellarium/stellarium/trunk/view/head:/src/gui/ViewDialog.cpp#L189

[Mykyta Sytyi (nsytyi)]

yes, but LandscapeMgr does not use that flag. Only set it and shows on the screen.

[treaves (treaves)]

No, it is very mush used. In Qt Creator, it is easy to click-through and see this.
http://bazaar.launchpad.net/~stellarium/stellarium/trunk/view/head:/src/core/modules/Landscape.cpp#L234

[Alexander Wolf (alexwolf)]

Diff: http://bazaar.launchpad.net/~stellarium/stellarium/trunk/revision/5426