Having unlocked a trophy should trigger re-checking achievements

[Rafał Cieślak]

Having unlocked a trophy should trigger re-checking achievements, because it is possible that some of them have been already completed.

Example case: I am a registered user on LP, and have already filled a bunch of bug reports.
I run the accomplishments system for the very first time. The "first bug reported" trophy is locked, therefore I get only the "registered on LP" trophy - which unlocks the "first bug reported" trophy. However, to get that one, I need to either use the "Check Accomplishments" command from the GUI app, or restart the daemon.
The daemon should check whether I have already completed the "first bug report" trophy automatically (without my inconvenience) as soon as the "registered on LP" accomplishment is validated.
Or, in other words, unlocking any new trophy should immediately trigger re-checking all available trophies.

[Jono Bacon (jonobacon)]

I think this makes sense. It would be useful if the script runner specifically runs the accomplishments that were unclocked to save re-running everything again.

[Rafał Cieślak (rafalcieslak256)]

Implementing that may get very tricky. Just re-running everything is very simple, but running a list of accomplishments would require 1) determining the list of just-unlocked accomplishments 2) passing that list to run_scripts_* 3) having scriptrunner select and run only these that are on the list. This fix will probably mess up the API a bit.

[Jono Bacon (jonobacon)]

Agreed. Let's just re-run the whole set again; I think that makes most sense.