vm-new fails when no display is available

[Max Brustkern]

On Oneiric amd64 desktop, with DISPLAY not properly set, if I run:
./vm-new -f -r -b virbr0 -t server oneiric i386 test
in the vm-tools directory on revision 787, virt-install runs and begins the vm initialization process, but immediately exits when it cannot display the console due to the lack of an X server. The script then continues up to vm-cmd, which runs vm_wait and waits for the vm to come up. Unfortunately, when the installer finishes, the vm halts instead of rebooting, and vm-cmd has already detected it as running, it will not try to start it again.

[Max Brustkern (nuclearbob)]

I've attached a patch that adds --noautoconsole to the list of virt-install options, then waits 30 minutes for VM to finish installation and shut down before proceeding. Please let me know if this is a reasonable solution.

[Max Brustkern (nuclearbob)]

Here is a better patch that uses vm_running from libvm.sh.

[Marc Deslauriers (mdeslaur)]

I like seeing the progress of my vm installation. How about detecting if DISPLAY is missing and only then adding --noautoconsole? Or it could be an extra command line option...something like vm-new -h for "headless"...

[Max Brustkern (nuclearbob)]

Here is a new patch which only adds --autoconsole to the arguments when $DISPLAY is empty. -h currently displays the help info, but I can implement that on another letter if that's desirable.

[Max Brustkern (nuclearbob)]

I've updated the patch to include header tags as described here:
https://wiki.ubuntu.com/PackagingGuide/PatchSystems?action=show&redirect=UbuntuDevelopment%2FPatchTaggingGuidelines#Patch_Tagging_Guidelines

[Max Brustkern (nuclearbob)]

My previous patch called local outside of a function, which works in bash but not in dash. The attached version corrects that.

[Max Brustkern (nuclearbob)]

I've added a -v option that invokes the option regardless of the contents of $DISPLAY.

[Marc Deslauriers (mdeslaur)]

ACK on the patch. Commited. Thanks!