Eventlet monkey_patch done too late ?

Bug #967440 reported by Cedric Brandily
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Medium
Joseph Heck

Bug Description

Hi everyone,

eventlet monkey patching seems to be done too late.

Indeed monkey patching is done in keystone-all script when keystone.wsgi module is imported.
So every module imported before could refer to non patched code ...
More precisely paste.deploy module is imported (don't know the impact), also keystone.config module which imports keystone.common.logging ... or logging does blocking actions (file writes) so logging could refer to unpatched functions.

Normally, eventlet patching must be the first to do in keystone-all script so just after the docstring and the licence in order to avoid import troubles.

PS: i refer to current keystone trunk

description: updated
Thierry Carrez (ttx)
tags: added: essex-rc-potential
Revision history for this message
Joseph Heck (heckj) wrote :

not sure, but it's an easy tweak...

Changed in keystone:
status: New → Opinion
importance: Undecided → Medium
assignee: nobody → Joseph Heck (heckj)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/6000

Changed in keystone:
status: Opinion → In Progress
Joseph Heck (heckj)
tags: removed: essex-rc-potential
Revision history for this message
Adam Young (ayoung) wrote :

Fixed with 81cb2ab2f5b7bdcd372491731750687e31c15ae2

Changed in keystone:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in keystone:
milestone: none → folsom-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: folsom-3 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.