cairo clock plug-in icon text gets lost against a matching background

[Tim]

If I set the icon's text colour to any colour, a window of the matching colour behind it makes the text invisible.

I can workaround by setting a background picture for the icon, but that's no fun.

I wrote a working fix, simply adding a configurable outline to the text: any colour and sensible widths.

The patch is a git patch (sorry), and doesn't include the CMakeLists.txt VERSION_CLOCK bump.

~/src/cairo-dock-plug-ins-2.4.0~2.1

[Matthieu Baerts (matttbe)]

Hello,

Thank you for this bug report and this patch. I (or Fab) will try to have a look at this asap.
But did you try the current development version (3.0.0.0rc1)? A few things have changed about the numeric view of this Clock applet ;)

[Tim (tim-launchpad-o)]

Hi,

I didn't try the current version because I'm not familiar with intertwingling different releases of Ubuntu (and frankly, I kinda just wanted a quick here-and-now solution).

I notice the patch isn't indented nicely, and I didn't add a conditional to avoid drawing the outline at all if the width == 0; I'm happy to upload a new patch with those fixes, but if things have changed, it sounds like that might be moot (and those're kinda trivial changes anyway).

Cheers!

[Matthieu Baerts (matttbe)]

Hi,

If you're using Ubuntu, you can easily test the 3.0.0.0rc1 version by adding our "weekly ppa": http://glx-dock.org/ww_page.php?p=ppa%20Weekly
But you can also use a script to quickly and easily download and install the current development version: http://glx-dock.org/ww_page.php?p=From%20BZR&lang=en#3-Debian%20/%20Ubuntu

BTW: I think it's maybe better to include your patch on the next version because it adds new options on the config panel (which have to be translated and tested)

[Tim (tim-launchpad-o)]

Hi.

Thanks for the clue-in: I'll maybe look at 3.0 in my copious spare time. :o)

I'm comfortable if you want to defer the patch to 3.0 - it's there if anyone wants to apply it for 2.4, and the background picture is probably sufficient workaround for most folks.

Just checking: were you wanting me to recreate the patch vs 3.0?

Cheers.

[Matthieu Baerts (matttbe)]

> Just checking: were you wanting me to recreate the patch vs 3.0?
No, I guess I will be able to port it to the 3.1 version (just after the release of the 3.0 version). But if you've free time, don't hesitate to test the 3.0.0.0rc1 version because a few things have changed (e.g. we no longer use the "ink" variable, the drawing is cleaner, etc.).

PS: Don't hesitate to re-post a message here after the release of the 3.0 version ;)

[Fabounet (fabounet03)]

so we're going to enter 3.1 now, I think we can apply the patch (although I don't think we need to make the linewidth customizable, 1 pixel around each text lines is probably a good value). :-)

[Tim (tim-launchpad-o)]

I... think I'd disagree with you on the line width, unless that's a '1 screen pixel' border, regardless of scaling. I think partially sighted folks would also prefer to have the option to make the border more substantial: if you can't focus properly, a thin border doesn't help distinguish white ink from white paper.

I've just upgraded to the latest Ubuntu - I presume this patch will appear there shortly?

Cheers.

[Matthieu Baerts (matttbe)]

Hello,
I just commited your changes on BZR[1]!
Thank you for the patch ;)

Don't hesitate to test it and propose any other modifications ;)

> I've just upgraded to the latest Ubuntu - I presume this patch will appear there shortly?
It's not possible to add new features on this Ubuntu version (since February 16th) but you can add our Weekly PPA[2] and wait for the new version.

[1] Rev 2382 and 2383 - https://code.launchpad.net/~cairo-dock-team/cairo-dock-plug-ins/plug-ins )
[2] http://glx-dock.org/ww_page.php?p=ppa%20Weekly

[Matthieu Baerts (matttbe)]

PS: with this new revisions, we can have that:
http://uppix.net/8/8/2/5f9a9fe5124d2c1781b1cb8b0b7b8.png
http://uppix.net/d/f/c/20d98c33cb16d6027604504c897af.png

Or if we just want to have a larger outline:
http://uppix.net/b/1/6/c8d11cb16c98043063f7ee2d27bdc.png => http://uppix.net/a/e/8/6b060dd59eab5a316b68bbd4a756c.png