Make GTCli more robust
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
GTG |
Fix Released
|
High
|
Xuan (Sean) Hu |
Bug Description
There are several crashes in gtcli utility (./gtcli), we need to solve all of them!
> ./gtcli show 'nonExisting'
Traceback (most recent call last):
File "./gtcli", line 348, in <module>
show_task(tid)
File "./gtcli", line 96, in show_task
task_data = timi.GetTask(tid)
File "/usr/lib/
return self._proxy_
File "/usr/lib/
**keywords)
File "/usr/lib/
message, timeout)
dbus.exceptions
File "/usr/lib/
retval = candidate_
File "/usr/share/
File "/usr/share/
AttributeError: 'NoneType' object has no attribute 'get_id'
> ./gtcli list all
# it shows nothing but it should shove the same output as ./gtcli list
> ./gtcli count all
0
# it should return the same number as ./gtcli count
> ./gtcli summary all
# it returns for every day 0, it should return the same output as ./gtcli summary
> ./gtcli postpone 'non-existing' tomorrow
Traceback (most recent call last):
File "./gtcli", line 341, in <module>
postpone(
File "./gtcli", line 125, in postpone
tasks = [ timi.GeTask(
File "/usr/lib/
return self._proxy_
File "/usr/lib/
**keywords)
File "/usr/lib/
message, timeout)
dbus.exceptions
File "/usr/lib/
(candidate_
File "/usr/lib/
raise UnknownMethodEx
UnknownMethodEx
[2] SegFault (20:27) trunk > ./gtcli close 'nonexisting'
Traceback (most recent call last):
File "./gtcli", line 335, in <module>
close_task(tid)
File "./gtcli", line 89, in close_task
task_data = timi.GetTask(tid)
File "/usr/lib/
return self._proxy_
File "/usr/lib/
**keywords)
File "/usr/lib/
message, timeout)
dbus.exceptions
File "/usr/lib/
retval = candidate_
File "/usr/share/
File "/usr/share/
AttributeError: 'NoneType' object has no attribute 'get_id'
Related branches
- Izidor Matušov: Approve (running, code)
-
Diff: 197 lines (+64/-31)3 files modifiedGTG/gtk/dbuswrapper.py (+8/-3)
gtcli (+55/-27)
gtcli_bash_completion (+1/-1)
Changed in gtg: | |
assignee: | nobody → huxuan (huxuan) |
status: | Confirmed → In Progress |
Changed in gtg: | |
status: | In Progress → Fix Committed |
Changed in gtg: | |
status: | Fix Committed → Fix Released |