multiple leaks in datetime's preferences page ui
Bug #965533 reported by
Charles Kerr
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Indicator Date and Time |
Fix Released
|
Low
|
Charles Kerr |
Bug Description
Our preferences UI page has several leaks:
* Every time we pull COL_NAME from our model, we leak the string
* Same for COL_ZONE
* Same for COL_TIMEZONE_
* Same for COL_TIMEZONE_
* The return value of g_variant_
Related branches
lp:~charlesk/indicator-datetime/fix-location-leak
- Conor Curran (community): Approve
-
Diff: 139 lines (+36/-26)1 file modifiedsrc/datetime-prefs-locations.c (+36/-26)
lp:~indicator-applet-developers/ubuntu/precise/indicator-datetime/upstream
- Ken VanDine: Pending requested
-
Diff: 777 lines (+263/-171)13 files modifiedChangeLog (+28/-0)
Makefile.am (+1/-35)
Makefile.am.coverage (+48/-0)
Makefile.in (+47/-41)
configure (+100/-64)
configure.ac (+4/-2)
data/Makefile.in (+0/-1)
debian/changelog (+10/-0)
m4/gcov.m4 (+13/-10)
src/Makefile.in (+0/-1)
src/datetime-prefs.c (+1/-8)
src/datetime-service.c (+11/-8)
tests/Makefile.in (+0/-1)
lp:~ubuntu-desktop/indicator-datetime/ubuntu
- Indicator Applet Developers: Pending requested
-
Diff: 285 lines (+248/-0) (has conflicts)3 files modifieddebian/changelog (+204/-0)
debian/control (+35/-0)
src/datetime-service.c (+9/-0)
Changed in indicator-datetime: | |
importance: | Undecided → Low |
status: | New → In Progress |
assignee: | nobody → Charles Kerr (charlesk) |
status: | In Progress → Fix Committed |
Changed in indicator-datetime: | |
status: | Fix Committed → Fix Released |
Changed in indicator-datetime: | |
milestone: | none → 0.3.93 |
To post a comment you must log in.