Tests do not build when libgtest-dev is installed but libgtest isn't
Bug #964248 reported by
Sam Spilsbury
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Compiz Core |
Fix Released
|
Medium
|
Sam Spilsbury | ||
Bug Description
According to the Google Test documentation[1], it isn't mandatory for distributions to ship the compiled gtest library, but instead applications are expected to use the shipped sources to compile it locally.
Currently FindGTest.cmake only searches for the headers /and/ the library, and since the library is no longer shipped in Ubuntu, GTest is not found and the tests do not build. The fix is to add GTEST_ROOT_DIR as part of the build process so that it is linked as a static lib should searching for the dynamic one fail.
[1] http://
Related branches
lp:~smspillaz/compiz-core/compiz-core.fix_964248
- Alan Griffiths: Approve
- Daniel van Vugt: Approve
-
Diff: 33 lines (+24/-0)1 file modifiedCMakeLists.txt (+24/-0)
| Changed in compiz-core: | |
| status: | New → Confirmed |
| importance: | Undecided → Medium |
| assignee: | nobody → Sam Spilsbury (smspillaz) |
| milestone: | none → 0.9.7.4 |
| description: | updated |
| Changed in compiz-core: | |
| milestone: | 0.9.7.4 → none |
Revision history for this message
| Daniel van Vugt (vanvugt) wrote | #1 |
| Changed in compiz-core: | |
| milestone: | none → 0.9.7.6 |
| status: | Confirmed → Fix Committed |
| milestone: | 0.9.7.6 → 0.9.7.4 |
Revision history for this message
| Daniel van Vugt (vanvugt) wrote | #2 |
| Changed in compiz-core: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fix committed into lp:compiz-core at revision 3071