rule router default behavior is not behaving as expected

[Pascal Hahn]

When using the rule based router, there is a requirement for a default rule to be set up. My expectation was that the destination of the default rule is only being used if there is no other rule that has a matching pattern and a whitelisted destination.

The behavior is that the default rules' destination receives every datapoint, basically it's behaving like a standard rule with the .+ or similar pattern.

My proposal is to have change the behavior of the rule router to only use the default rule if there were no destinations found in all the other rules set up.

Patch attached.

[Michael Leinartas (mleinartas)]

Hm.. I'll have to look at the source history to see how this bug was introduced. Your expectation is correct - the first rule that matches should cause processing to stop.

[Michael Leinartas (mleinartas)]

Thanks for the find and the patch. It looks like this broke in r521 during a refactor of the carbon-relay code. Along with a fix, I've added the ability to allow matched patterns to pass through when specified which makes it easier to copy a group of metrics.

[Michael Leinartas (mleinartas)]

Fix committed in r738