shortsighted shipwright (ship in pond)

[Astuur]

The shipwrigt chooses an unsuitable place to build the ship.
Maybe there could be a check, especially when two alternatives are available, to verify that the
water body to build the ship in, is not too small?
See attachment

[Astuur (wolfsteinmetz)]

Want to add that the situation shown in the picture above
crashes the game as soon as the second ship is finished,
if you do not stop the shipwright.
Space problem, probably.

[Nasenbaer (nasenbaer)]

Best way would be to check, whether the water area has at least two port buildspaces connected to it, to ensure, that ships would make sense.

[Hans Joachim Desserud (hjd)]

Nice catch. :) Could you please report the problem in comment #2 as a separate issue? If there is a space problem that will probably be triggered no matter the size of the sea, if you build, say, a couple of hundred ships. (And someone will do this at some point.)

[SirVer (sirver)]

S2 had an index for each "pont" in its map format iirc. A water without a port had index 0. They did not use it for the ships though because the ship builder could be as stupid as the one in widelands currently is.

[Frank Pieper (frank-pieper-1)]

I think the straightest Way is to implement an Idea of connected Water-Area and let the Player select which Water gets next Ships. If he don't select to send to Ponds it never happened (but he can if he want if he think a Pond to be large enough for his Needs).

[SirVer (sirver)]

Setting to incomplete for bug sweeping.

[Launchpad Janitor (janitor)]

[Expired for widelands because there has been no activity for 60 days.]

[SirVer (sirver)]

I think #3 is the way to go

[GunChleoc (gunchleoc)]

#3 would break the Atlantean scenario though - we would need to add some port spaces to the map.

[GunChleoc (gunchleoc)]

Fixed in build20-rc1