wrong error for blockdev-snapshot-sync

[Paolo Bonzini]

From Laszlo Ersek:

>> + proto_drv = bdrv_find_protocol(snapshot_file);
>> if (!proto_drv) {
>> - qerror_report(QERR_INVALID_BLOCK_FORMAT, format);
>> - ret = -1;
>> - goto out;
>> + error_set(errp, QERR_INVALID_BLOCK_FORMAT, format);
>> + return;
>> }
>
> I don't understand the logic here (based on the error message). We
> specified "format" for the case when a completely new snapshot file has
> to be created. If the file exists already, then bdrv_find_protocol()
> tries to find the driver for it. If that fails, then we must report an
> error indeed, but instead of referring to "format", we'd have to report
> the "scheme" from the beginning of "snapshot_file".

[Thomas Huth (th-huth)]

Which version of QEMU was this? Is this still a problem with the latest version of QEMU?

[John Snow (jnsnow)]

I can't find anything in the blockdev-snapshot-sync path that has this code in it still. Think it's a non-issue in 2017.

[Launchpad Janitor (janitor)]

[Expired for QEMU because there has been no activity for 60 days.]