Audit info setting fails in some cases

[Bill Erickson]

From bug #893645

AppUtils.pm set_audit_info expects the first parameter to be an open-ils.store OpenSRF::AppSession. In some contexts, it's passed an authtoken instead. This results in failures with (for example) creating payments.

I found a few examples:

open-ils.circ.money.grocery.create
Various API calls in Circ/StatCat.pm, Circ/Transit.pm and Circ/Survey.pm.

This may not be an exhaustive list. For most of these, it looks like a simple variable replacement (e.g. s/user_session/session/) will suffice.

[Thomas Berezansky (tsbere)]

Actually, it looks like I forgot to add the session variable at all to most of those calls, so where 4 arguments should be passed in only 3 were.

The branch below corrects that.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/tsbere/fix_set_audit_info

[Bill Erickson (berick)]

Tested and pushed to master. Thanks!