OpenLP won't start due to media player setting

[Jonathan Corwin]

I get the following error when starting OpenLP.
It doesn't occur prior to r1903

It appears to be due to me not having any media players set in the settings, although I don't recall deselecting them all!

2012-03-17 22:19:11,423 openlp.core.lib.pluginmanager INFO initialising plugins media in a True state
2012-03-17 22:19:11,427 root ERROR Traceback (most recent call last):
  File "openlp.pyw", line 42, in <module>
    main()
  File "C:\Users\Jonathan\Documents\projects\openlp\trunk\openlp\core\__init__.py", line 291, in main
    sys.exit(app.run(qt_args))
  File "C:\Users\Jonathan\Documents\projects\openlp\trunk\openlp\core\__init__.py", line 130, in run
    self.mainWindow = MainWindow(self.clipboard(), self.args)
  File "C:\Users\Jonathan\Documents\projects\openlp\trunk\openlp\core\ui\mainwindow.py", line 683, in __init__
    self.pluginManager.initialise_plugins()
  File "C:\Users\Jonathan\Documents\projects\openlp\trunk\openlp\core\lib\pluginmanager.py", line 193, in initialise_plugins
    plugin.initialise()
  File "C:\Users\Jonathan\Documents\projects\openlp\trunk\openlp\core\lib\plugin.py", line 293, in initialise
    self.mediaItem.initialise()
  File "C:\Users\Jonathan\Documents\projects\openlp\trunk\openlp\plugins\media\lib\mediaitem.py", line 225, in initialise
    self.populateDisplayTypes()
  File "C:\Users\Jonathan\Documents\projects\openlp\trunk\openlp\plugins\media\lib\mediaitem.py", line 255, in populateDisplayTypes
    self.displayTypeComboBox.addItem(mediaPlayers[player].original_name)
KeyError: u''
None

[Jonathan Corwin (j-corwin)]

This happens if you run a recent version, and select only VLC as the media player.
Then run an older pre-VLC support version.

[rimach (crichter)]

Hello Jonathan,

could you retest this issue with a build after my latest change:
http://bazaar.launchpad.net/~openlp-core/openlp/trunk/revision/1913

[Jonathan Corwin (j-corwin)]

Well it now starts OK.
Does still leave no media player selected, so a stack trace appears if someone attempts to play a video. However at least now the program starts, it can be fixed in the settings.

Traceback (most recent call last):
  File "C:\Users\Jonathan\Documents\projects\openlp\198\openlp\core\lib\mediamanageritem.py", line 466, in onClickPressed
    self.onLiveClick()
  File "C:\Users\Jonathan\Documents\projects\openlp\198\openlp\core\lib\mediamanageritem.py", line 508, in onLiveClick
    self.goLive()
  File "C:\Users\Jonathan\Documents\projects\openlp\198\openlp\core\lib\mediamanageritem.py", line 515, in goLive
    serviceItem = self.buildServiceItem(item, remote=remote)
  File "C:\Users\Jonathan\Documents\projects\openlp\198\openlp\core\lib\mediamanageritem.py", line 585, in buildServiceItem
    if self.generateSlideData(serviceItem, item, xmlVersion, remote):
  File "C:\Users\Jonathan\Documents\projects\openlp\198\openlp\plugins\media\lib\mediaitem.py", line 202, in generateSlideData
    self.mediaController, filename, False, False):
  File "C:\Users\Jonathan\Documents\projects\openlp\198\openlp\core\ui\media\mediacontroller.py", line 325, in video
    isValid = self.check_file_type(controller, display)
  File "C:\Users\Jonathan\Documents\projects\openlp\198\openlp\core\ui\media\mediacontroller.py", line 369, in check_file_type
    player = self.mediaPlayers[title]
KeyError: u''

[Jonathan Corwin (j-corwin)]

Sorry was testing wrong branch. All appears OK now.