Compiz Core

Coverity PW.PARAMETER_HIDDEN - CID 10012 - gtk/window-decorator/decorator.c - Window win = d->button_windows[i].window; declaration hides parameter "win" (declared at line 232)

Bug #957600 reported by Product Strategy Coverity Bug Uploader on 2012-03-17

This bug affects 1 person

	Status	Importance	Assigned to	Milestone
Compiz	Fix Released	Low	Stephen M. Webb	Compiz 0.9.12.0
Compiz Core	Won't Fix	Medium	Unassigned
compiz (Ubuntu)	Fix Released	Undecided	Unassigned

Bug Description

This bug is exported from the Coverity Integration Manager on Canonical's servers. For information on how this is done please see this website: https://wiki.ubuntu.com/CanonicalProductStrategy/Coverity
CID: 10012
Checker: PW.PARAMETER_HIDDEN
Category: No category available
CWE definition: No definition available
File: /tmp/buildd/compiz-0.9.7.0~bzr3025/gtk/window-decorator/decorator.c
Function: No function name available
Code snippet:
386 else if (!d->frame_window &&
387 (*theme_get_button_position) (d, i, width, height,
388 &x, &y, &w, &h))
389 {
CID 10012 - PW.PARAMETER_HIDDEN
declaration hides parameter "win" (declared at line 232)
390 Window win = d->button_windows[i].window;
391 XMapWindow (xdisplay, win);
392 XMoveResizeWindow (xdisplay, win, x, y, w, h);
393
394 BoxPtr box = &d->button_windows[i].pos;
395 box->x1 = x;

Tags:

Related branches

lp:~bregma/compiz/lp-957600

Merged into lp:compiz/0.9.12 at revision 3897

Christopher Townsend (community): Approve on 2014-10-29

PS Jenkins bot (community): Approve (continuous-integration) on 2014-10-29

Revision history for this message

Product Strategy Coverity Bug Uploader (coverity-uploader) wrote on 2012-03-17: compiz-core-0.9.5: /tmp/buildd/compiz-0.9.7.0~bzr3025/gtk/window-decorator/decorator.c

compiz-core-0.9.5: /tmp/buildd/compiz-0.9.7.0~bzr3025/gtk/window-decorator/decorator.c Edit (220.9 KiB, text/html)

Source file with Coverity annotations.

Changed in compiz-core:
importance:	Undecided → Medium

Sam Spilsbury (smspillaz) on 2012-05-18

Changed in compiz:
importance:	Undecided → Medium

MC Return (mc-return) on 2013-07-06

summary:	- Coverity PW.PARAMETER_HIDDEN - CID 10012 + Coverity PW.PARAMETER_HIDDEN - CID 10012 - gtk/window- + decorator/decorator.c - declaration hides parameter "win" (declared at + line 232)
Changed in compiz:
milestone:	none → 0.9.10.0
summary:	Coverity PW.PARAMETER_HIDDEN - CID 10012 - gtk/window- - decorator/decorator.c - declaration hides parameter "win" (declared at - line 232) + decorator/decorator.c - Window win = d->button_windows[i].window; + declaration hides parameter "win" (declared at line 232)

Sam Spilsbury (smspillaz) on 2013-07-22

Changed in compiz:
milestone:	0.9.10.0 → 0.9.10.2

MC Return (mc-return) on 2013-07-24

Changed in compiz:
milestone:	0.9.10.2 → 0.9.11.0

Stephen M. Webb (bregma) on 2014-10-26

no longer affects:	compiz-core/0.9.5
Changed in compiz:
importance:	Medium → Low
milestone:	0.9.11.0 → 0.9.12.0
status:	New → Triaged
Changed in compiz-core:
status:	New → Won't Fix

Stephen M. Webb (bregma) on 2014-10-29

Changed in compiz:
assignee:	nobody → Stephen M. Webb (bregma)
status:	Triaged → In Progress

Revision history for this message

Launchpad Janitor (janitor) wrote on 2014-11-03:

This bug was fixed in the package compiz - 1:0.9.12+15.04.20141031-0ubuntu1

---------------
compiz (1:0.9.12+15.04.20141031-0ubuntu1) vivid; urgency=low

  [ Stephen M. Webb ]
  * filter debian/ from upstream dist tarball (LP: #1075995)
  * removed distro-patch for #873384 because it's now upstream (LP:
    #873384)
  * removed inappropriate executable permissions from some source and
    data files (LP: #1086165)
  * window_decorator: renamed a local to unhide a parameter (LP:
    #957600)
  * opengl plugin: free shaders and uniforms (LP: #1227449)
  * debian/compizconfig: renamed from debian/config to avoid debconf
    clashes (LP: #1156294)
  * animation plugin: initialize mPrevAnimSelectionRow (LP: #1101630)

[ Klaus Knopper ]
* Forces non-opaque pointer in the ezoom plugin. (LP: #1362005)

  [ Henry Hu ]
  * place plugin: correct min and default placement modes in
    configuration

[ Matija Skala ]
* remove 'extern "C"' hack (LP: #1286562)

[ Dariusz Gadomski ]
* CompScreen: Save focused window id before changing viewport.
-- Ubuntu daily release <email address hidden> Fri, 31 Oct 2014 17:03:50 +0000