Many effects do not work with Gtk# 2.12.11

[Balló György]

Most of the effects not work, e. g. Black and white, Invert Colors, Clouds, Bulge, Twist. If I apply them, the image remains unchanged. Effects that still work: Edge Detect, Relief.

Package versions:
- pinta 1.1
- gtk-sharp 2.12.11
- mono-addins 0.6.2

Tested also with the latest version of Pinta from GIT with the same result.

[grofaty (grofaty)]

I have tested effects you described as not working in:
- Pinta 1.1 on Windows XP and
- Pinta latest version from GIT on Ubuntu 11.10
and on both system everything is working as designed.

Can you please provide what is your operating system and version. Can you also provide more info: have you draw a new picture or opened some file and executing effects on it. Can you attach the file you are trying to create effects on.

[Balló György (ballogy)]

The system is Arch Linux. The result is the same if I open a picture or start drawing a new one. I can see the effects on history panel but the picture remains unchanged. And I don't get any error messages or exceptions.

[awol (awol99)]

Macintosh OS X.7 - Lion. Pinta1.3

i agree - most Effects do not work. they appear in history but produce no preview or changes to the image

[awol (awol99)]

still with Macintosh OS X.7 - Lion. Pinta1.3

running in MonoDevelop there is no error from "Gaussian Blur" - but no image results either.

the Effect "Edge Detect" produces this error -

System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.NullReferenceException: Object reference not set to an instance of an object
  at Pinta.Gui.Widgets.AnglePickerWidget..ctor () [0x0000c] in /Users/awol/Downloads/pinta-1.3/Pinta.Gui.Widgets/Widgets/AnglePickerWidget.cs:22
  at Pinta.Gui.Widgets.SimpleEffectDialog.CreateAnglePicker (System.String caption, System.Object o, System.Reflection.MemberInfo member, System.Object[] attributes) [0x0001b] in /Users/awol/Downloads/pinta-1.3/Pinta.Gui.Widgets/Dialogs/SimpleEffectDialog.cs:308
  at Pinta.Gui.Widgets.SimpleEffectDialog.BuildDialog () [0x001bf] in /Users/awol/Downloads/pinta-1.3/Pinta.Gui.Widgets/Dialogs/SimpleEffectDialog.cs:109
  at Pinta.Gui.Widgets.SimpleEffectDialog..ctor (System.String title, Gdk.Pixbuf icon, System.Object effectData) [0x00092] in /Users/awol/Downloads/pinta-1.3/Pinta.Gui.Widgets/Dialogs/SimpleEffectDialog.cs:61
  at Pinta.EffectHelper.LaunchSimpleEffectDialog (Pinta.Core.BaseEffect effect) [0x0003e] in /Users/awol/Downloads/pinta-1.3/Pinta.Effects/Utilities/EffectHelper.cs:45
  at Pinta.Effects.EdgeDetectEffect.LaunchConfiguration () [0x00000] in /Users/awol/Downloads/pinta-1.3/Pinta.Effects/Effects/EdgeDetectEffect.cs:48
  at Pinta.Core.LivePreviewManager.Start (Pinta.Core.BaseEffect effect) [0x001e3] in /Users/awol/Downloads/pinta-1.3/Pinta.Core/Managers/LivePreviewManager.cs:123
  at Pinta.Core.EffectsManager+<RegisterEffect>c__AnonStorey8.<>m__A (System.Object sender, System.EventArgs e) [0x00000] in /Users/awol/Downloads/pinta-1.3/Pinta.Core/Managers/EffectsManager.cs:99
  at (wrapper managed-to-native) System.Reflection.MonoMethod:InternalInvoke (System.Reflection.MonoMethod,object,object[],System.Exception&)
  at System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00000] in <filename unknown>:0
  --- End of inner exception stack trace ---
  at System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00000] in <filename unknown>:0
  at System.Reflection.MethodBase.Invoke (System.Object obj, System.Object[] parameters) [0x00000] in <filename unknown>:0
  at System.Delegate.DynamicInvokeImpl (System.Object[] args) [0x00000] in <filename unknown>:0
  at System.MulticastDelegate.DynamicInvokeImpl (System.Object[] args) [0x00000] in <filename unknown>:0
  at System.Delegate.DynamicInvoke (System.Object[] args) [0x00000] in <filename unknown>:0
  at GLib.Signal.ClosureInvokedCB (System.Object o, GLib.ClosureInvokedArgs args) [0x00000] in <filename unknown>:0
  at GLib.SignalClosure.Invoke (GLib.ClosureInvokedArgs args) [0x00000] in <filename unknown>:0
  at GLib.SignalClosure.MarshalCallback (IntPtr raw_closure, IntPtr return_val, UInt32 n_para...

[Krzysztof Majzerowicz-Jaszcz (majzerowicz)]

I agree as well. Most effects do not work at all, no supicious output in the console.

System:
Arch Linux x64, kernel 3.4.3, mono v2.10.8-1, mono-addins 0.6.2-2, gtk-sharp-2 v2.12.11-1 => from official repos, pinta 1.3-1 from AUR.

[Luke Mondy (luke-s-mondy)]

OSX 10.7.4
Pinta 1.3
Mono add-ins 0.6

I agree with other people - most effects do not produce a result, and no console output is apparent.

[Balló György (ballogy)]

Okay, I found that this commit in gtk-sharp causes the problem:
https://github.com/mono/gtk-sharp/commit/73368d4d78d54f1012a6216d69d9ab0bcbded164

It was committed in the 2.12.11 release of gtk-sharp, so systems with 2.12.10 or older (e.g. Ubuntu) are not affected.

So could somebody check why this commit breaks the effects in Pinta?

[Cameron White (cameronwhite91)]

Fixed: https://github.com/PintaProject/Pinta/commit/1d73e538d1f3dde1cfc594b401cbda58c84e00c0

Thanks for tracking down the commit that caused this problem!

[Balló György (ballogy)]

Thanks for the fix! I experienced problems with Fix Motion Blur and Pixelate effects due a typo and an infinite loop. The attached patch fixes this issue.

[Cameron White (cameronwhite91)]

Thanks, I've added that patch: https://github.com/PintaProject/Pinta/commit/76b0da0f9e28d188030fa7e6f2cce04bab115367