don't use zipfile's context manager as it won't work on py2.6
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Dashboard (Horizon) |
Fix Released
|
Medium
|
Ionuț Arțăriși |
Bug Description
Context managers were introduced in the zipfile module in python 2.7[1], so they don't work on py2.6. I noticed this failing unittest on py2.6
[1] http://
=======
ERROR: test_ec2_
-------
Traceback (most recent call last):
File "/var/lib/
res = self.client.
File "/usr/lib64/
response = super(Client, self).post(path, data=data, content_
File "/usr/lib64/
return self.request(**r)
File "/usr/lib64/
response = callback(request, *callback_args, **callback_kwargs)
File "/var/lib/
return view_func(request, *args, **kwargs)
File "/var/lib/
return view_func(request, *args, **kwargs)
File "/var/lib/
return view_func(request, *args, **kwargs)
File "/usr/lib64/
return self.dispatch(
File "/usr/lib64/
return handler(request, *args, **kwargs)
File "/var/lib/
return self.get(self, request, *args, **kwargs)
File "/var/lib/
form, handled = self.maybe_handle()
File "/var/lib/
self.form, self.handled = form.maybe_
File "/var/lib/
exceptions.
File "/var/lib/
return form, form.handle(
File "/var/lib/
redirect=
File "/var/lib/
with zipfile.
AttributeError: ZipFile instance has no attribute '__exit__'
Changed in horizon: | |
assignee: | nobody → Ionuț Arțăriși (iartarisi) |
status: | New → In Progress |
Changed in horizon: | |
importance: | Undecided → Medium |
milestone: | none → essex-rc1 |
Changed in horizon: | |
status: | Fix Committed → Fix Released |
Changed in horizon: | |
milestone: | essex-rc1 → 2012.1 |
Reviewed: https:/ /review. openstack. org/5343 github. com/openstack/ horizon/ commit/ 53f15d9424bd613 7baf98187215520 abb6c545cc
Committed: http://
Submitter: Jenkins
Branch: master
commit 53f15d9424bd613 7baf98187215520 abb6c545cc
Author: Ionuț Arțăriși <email address hidden>
Date: Wed Mar 14 17:36:33 2012 +0100
don't use zipfile's context manager as it won't work on py2.6
Fixes bug: 955994
Change-Id: I436c667f496b10 d64281538692acc 10e327a8fdf