hardware plugin not reporting on upgrade

[David Britton]

In doing upgrade tests on the client, I noticed that hardware information was not reported. I traced through the code and I believe the problem is the registration of events that the hardware listens for.

in r470, a change was made to listen on message-type-acceptance-changed, which only seems to fire when events get added or removed from the accepted reporting types list coming back from the server. The effect of this seems to be to only report hardware when the message type list that the server accepts *changes*. Which of course happens when the client is first run on a virgin system, but when doing an upgrade, you will have a stored accepted_types list already in tact, but will have never reported hardware.

Looking at the other client modules, it looks like this should be reported with not only the call_on_accepted callback, but also the call_if_accepted callback which I think will report at startup regardless of state.

I'm attaching a branch with the proposed fix, which works as I expect, but has no tests, and may possibly be a naive implementation.

[Björn Tillenius (bjornt)]

I've added tests to the patch and commited it in r517.

I also filed bug 955899 about how to address this problem properly.