[FFe, UIFe] New animation for adding launchers for newly installed applications
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Unity |
Fix Released
|
Medium
|
Bilal Akhtar | ||
unity (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
As decided at UDS-P, Software Center should be integrated deeper with the Unity launcher. The spec for how it should happen, is here:
https:/
Here's a YouTube video demonstrating this in action (It's my video running Unity from my branch, see the attached branch for it):
http://
Now for the implementation details. I broke down implementation into two phases. First phase involved these features:
1) An app being installed is shown in the launcher with a tooltip "Waiting to install"
2) A progress bar on the launcher item displays the download/install progress.
3) When the app gets installed, the launcher items becomes usable, and the tooltip gets changed to the app name.
First phase (bug #761851) was implemented as part of this merge request here: https:/
It shipped as part of Unity 5.2. But due to the code getting refactored, the implementation broke right afterwards, as one line got missed out; see bug #932280 and the attached branch. I didn't realize this until the freezes had passed, and I wrote a one-line change to fix it, which remains unmerged until now: https:/
1) Animate the movement of the icon from the USC window to the Unity launcher.
2) Make the launcher icon wiggle when installation is complete.
3) Ensure the launcher icon doesn't start blinking when clicked in the "Waiting to install" phase.
Phase 2 fixes the regression as well as adds the above features. So, it introduces these changes, from Unity 5.2 (since in 5.2, phase 1 was working well, phase1 broke AFTER 5.2), that need FFe and UIFe:
1) The behavior changes (flying icon) rather than just a usual icon add.
2) Launcher icon wiggles when installation finishes, unlike 5.2, where it just became usable, with no extra effect.
Phase 2, along with tests, is contained in this merge request (branch is also linked to this bug): https:/
The YouTube video which I linked at the top of this description, is actually the above branch in action.
Do note that all changes mentioned above are needed in the unity package only. The software center side of the implementation has been in since before the freezes.
Testing: I've tested this branch thoroughly with all corner cases, etc. The linked branch also contains an autopilot test to ensure that the implementation never breaks in the future. The implementation is very stable, the few crashes I experienced last week were ironed out earlier this week, and never had issues since then.
Please review this FFe and UIFe request.
Ubuntu-doc ML posting: https:/
Ubuntu-translators ML posting: https:/
Related branches
- Alex Launi (community): Approve
- Thomi Richards (community): Needs Fixing
- Marco Trevisan (Treviño): Needs Fixing
- Matthew Paul Thomas (community): Approve (design)
- Unity Team: Pending requested
-
Diff: 458 lines (+213/-17)9 files modifiedplugins/unityshell/src/BamfLauncherIcon.h (+1/-1)
plugins/unityshell/src/Launcher.cpp (+7/-1)
plugins/unityshell/src/Launcher.h (+7/-3)
plugins/unityshell/src/LauncherController.cpp (+24/-8)
plugins/unityshell/src/SoftwareCenterLauncherIcon.cpp (+101/-2)
plugins/unityshell/src/SoftwareCenterLauncherIcon.h (+20/-0)
tests/autopilot/autopilot/emulators/unity/icons.py (+3/-0)
tests/autopilot/autopilot/emulators/unity/launcher.py (+14/-1)
tests/autopilot/autopilot/tests/test_launcher.py (+36/-1)
- Tim Penhey (community): Approve
- Marco Trevisan (Treviño): Needs Fixing
- Thomi Richards: Pending requested
- Alex Launi: Pending requested
- Matthew Paul Thomas: Pending (design) requested
-
Diff: 554 lines (+225/-42)10 files modifiedplugins/unityshell/src/BamfLauncherIcon.h (+1/-1)
plugins/unityshell/src/Launcher.cpp (+7/-1)
plugins/unityshell/src/Launcher.h (+7/-3)
plugins/unityshell/src/LauncherController.cpp (+32/-20)
plugins/unityshell/src/SoftwareCenterLauncherIcon.cpp (+93/-5)
plugins/unityshell/src/SoftwareCenterLauncherIcon.h (+23/-3)
tests/autopilot/autopilot/emulators/X11.py (+8/-6)
tests/autopilot/autopilot/emulators/unity/icons.py (+3/-0)
tests/autopilot/autopilot/emulators/unity/launcher.py (+14/-1)
tests/autopilot/autopilot/tests/test_launcher.py (+37/-2)
description: | updated |
description: | updated |
description: | updated |
Changed in unity: | |
milestone: | 5.8.0 → 5.10.0 |
Changed in unity: | |
status: | Triaged → Fix Committed |
Changed in unity (Ubuntu): | |
status: | Triaged → Fix Committed |
Changed in unity: | |
status: | Fix Committed → Fix Released |
Can anyone review this request soon? I'd like to ensure that this change lands in time for Unity 5.8 and I don't want the merge window to close before this request is approved. That might mean missing the Beta 2 deadline for this change.