test should return error while necessary environ not fulfilled
Bug #955053 reported by
TienFu Chen
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Checkbox |
Fix Released
|
Low
|
Daniel Manrique |
Bug Description
If environs needed by a test are not set. The test should not be fired and return failure.
Version:
checkbox 0.13.4
checkbox-
Report:
https:/
From above report, you can see the tests are fired even the necessary environs are not set.
And some tested passed, some failed(by the command return status)
Alternative, we should check environ first, like: test $OPEN_BG_SSID && TEST_COMMAND
Related branches
lp:~roadmr/checkbox/environ-test
- Marc Tardif (community): Approve
-
Diff: 99 lines (+27/-1)4 files modifiedcheckbox/tests/test_message_files.py (+19/-0)
debian/changelog (+3/-1)
jobs/power-management.txt.in (+1/-0)
jobs/stress.txt.in (+4/-0)
description: | updated |
Changed in checkbox: | |
status: | New → Incomplete |
Changed in checkbox: | |
status: | Incomplete → Confirmed |
Changed in checkbox: | |
status: | In Progress → Fix Committed |
Changed in checkbox: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
I don't quite see the point of this - unless maybe you make it so that the job results clearly displays which values weren't set.
As for the tests passing put failing to create the connection, did you create a wireless connection manually before they ran?