pt-table-checksum --check-slave-lag docs aren't clear

Bug #954588 reported by Fernando Ipar
16
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Percona Toolkit moved to https://jira.percona.com/projects/PT
Fix Released
Medium
Daniel Nichter

Bug Description

The documentation implies that if --check-slave-lag is used, pt-table-checksum will only check the lag for the specified slave.
However, the tool still tries to recurse down the replication hierarchy.

Is this expected behavior?
I understand --check-slave-lag as meaning "I only care about lag on this one slave, please just monitor that one", is that wrong?

Revision history for this message
Baron Schwartz (baron-xaprb) wrote :

When --check-slave-lag is used, pt-table-checksum should only connect to the specified server and shouldn't interact with any others at all. So this is a bug.

Changed in percona-toolkit:
status: New → Confirmed
importance: Undecided → Medium
tags: added: pt-table-checksum
Revision history for this message
Baron Schwartz (baron-xaprb) wrote :

The same problem occurs in pt-online-schema-change. That is reported in bug 1012681, which I have marked as a duplicate of this one.

Revision history for this message
Daniel Nichter (daniel-nichter) wrote :

Baron, I think --check-slave-lag means "only check lag on this slave", but that's separate from which slaves the tool connects to for other things like waiting for chunks to replicate. By default, all slaves' lag is checked, but if there's one that's always lagging or intentionally being lagged, then this option allows one to specify which slave is the "standard lagger". Using --recursion-method=dsn is the way to make the tool only connect to certain slaves.

So I don't think this is a bug; the tool has always worked this way concerning this option.

Changed in percona-toolkit:
milestone: none → 2.1.4
summary: - pt-table-checksum still tries to recurse down the replication hierarchy
- when --check-slave-lag is specified
+ pt-table-checksum recurses to slaves when --check-slave-lag is specified
Changed in percona-toolkit:
assignee: nobody → Daniel Nichter (daniel-nichter)
Revision history for this message
Daniel Nichter (daniel-nichter) wrote :

Fernando agrees that this isn't a bug but rather the docs not reading clearly.

tags: added: docs slave-recursion
summary: - pt-table-checksum recurses to slaves when --check-slave-lag is specified
+ pt-table-checksum --check-slave-lag docs aren't clear
Changed in percona-toolkit:
status: Confirmed → In Progress
Changed in percona-toolkit:
status: In Progress → Fix Committed
Brian Fraser (fraserbn)
Changed in percona-toolkit:
status: Fix Committed → Fix Released
Revision history for this message
Shahriyar Rzayev (rzayev-sehriyar) wrote :

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PT-499

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.