Simplify the version fetching
Bug #954252 reported by
Andrea Crotti
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| GNU Mailman |
Won't Fix
|
Undecided
|
Unassigned | ||
Bug Description
The version.py can be safely executed with execfile to extract the version number, instead of using regular expressions.
Related branches
lp:~andrea-crotti-0/mailman/version
- Barry Warsaw: Disapprove
-
Diff: 33 lines (+5/-12)1 file modifiedsetup.py (+5/-12)
Revision history for this message
| Andrea Crotti (andrea-crotti-0) wrote | #1 |
| Changed in mailman: | |
| status: | New → Won't Fix |
To post a comment you must log in.
I found out today that execfile doesn't exist anymore in python3k, so maybe it's not the best solution..
But leaving everything as it is, why bothering so much about the possibility to not find the file?
If opening the file fails than the directory structure is wrong, and same thing for the VERSION regexp matching, since both things are under control is not maybe easier to just let it blow up if something is wrong (of course it's no harm, just a few lines more)?