Invalid file name characters in song name causes OpenLyrics to crash
Bug #952533 reported by
Phill
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenLP |
Fix Released
|
Medium
|
Phill |
Bug Description
http://
Certain invalid file name characters can appear in song names. (in this example a tab, but new line, and others)
This causes the OpenLyrics exporter to crash. These be stripped from the file name. Ideally they would also be caught, and reported as a song error to the user.
Phill
Related branches
lp:~phill-ridout/openlp/bug952533
- Jonathan Corwin (community): Approve
- Raoul Snyman: Approve
- Meinert Jordan: Pending requested
-
Diff: 65 lines (+18/-4)2 files modifiedopenlp/core/utils/__init__.py (+3/-1)
openlp/plugins/songs/lib/__init__.py (+15/-3)
Changed in openlp: | |
milestone: | none → 1.9.9 |
status: | Confirmed → Fix Released |
To post a comment you must log in.
I managed to enter a tab and newline by copy and pasting them into the song edit title textbox.
So we need to
1. Ensure these characters can't be entered/pasted into the title textbox.
2. Ensure song imports strip them out too
3. Perhaps change the Re-index Songs to strip out any that exist already so people can fix their data.
4. Bullet proof the song export to remove invalid characters. Note it didn't crash for newline or \ / : etc, only for tab.