Song search is slow

[Andreas Preikschat]

Hello,

There has been some regression in the song search speed.

1.9.8
2012-03-11 13:03:06,375 songs.songsplugin INFO Songs Initialising
2012-03-11 13:03:06,390 openlp.plugins.songs.lib.mediaitem DEBUG Entire Song Search
2012-03-11 13:03:14,953 openlp.plugins.songs.lib.mediaitem DEBUG display results Song
2012-03-11 13:03:16,842 openlp.core.ui.mediadockmanager DEBUG Inserting Lieder dock

bzr1892
2012-03-11 12:27:18,467 songs.songsplugin INFO Songs Initialising
2012-03-11 12:27:18,500 openlp.plugins.songs.lib.mediaitem DEBUG Entire Song Search
2012-03-11 12:27:50,937 openlp.plugins.songs.lib.mediaitem DEBUG display results Song
2012-03-11 12:27:53,780 openlp.core.ui.mediadockmanager DEBUG Inserting Lieder dock

As you can see, displaying the search results takes much longer in the nightlys than in 1.9.8. I think it is due to http://bazaar.launchpad.net/~openlp-core/openlp/trunk/revision/1881 (the function call overhead is causing this). But maybe can confirm that.

Regards

PS: The database used for this contains 3216 songs.

[Andreas Preikschat (googol-deactivatedaccount)]

I cannot reproduce it.... Sorry :-)