diablo style responses to auth_token

Bug #951933 reported by Jesse Andrews
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Critical
Dolph Mathews

Bug Description

We have coverage for essex-style auth responses in the auth_token middleware:

   https://review.openstack.org/#change,5203

The middleware seems to support diablo style responses. We should update the comments about our supported responses:

https://github.com/openstack/keystone/blob/master/keystone/middleware/auth_token.py

        # FIXME(ja): I think we are checking in both places because:
        # tenant might not be returned, and there was a pre-release
        # that put tenant objects inside the user object?
        try:
            tenant_id = token['tenant']['id']
            tenant_name = token['tenant']['name']
        except:
            tenant_id = user.get('tenantId')
            tenant_name = user.get('tenantName')

And ensure test coverage

Changed in keystone:
assignee: nobody → Dolph Mathews (dolph)
Dolph Mathews (dolph)
Changed in keystone:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/5278

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/5278
Committed: http://github.com/openstack/keystone/commit/73af033ded8fe9ba54c37ab4f2a7553b3be1e450
Submitter: Jenkins
Branch: master

commit 73af033ded8fe9ba54c37ab4f2a7553b3be1e450
Author: Dolph Mathews <email address hidden>
Date: Tue Mar 13 12:27:53 2012 -0500

    Improved legacy tenancy resolution (bug 951933)

    Change-Id: Ia6fd5eb57e8d7f90328117351f7b814b1b4495dc

Changed in keystone:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in keystone:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: essex-rc1 → 2012.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.