"Save unsaved changes" dialog looks bad/wrong

[Andrea Basso]

As you can see here http://imagebin.org/202734 , buttons are on the left (and IMO the cancel should be on the left, but this is just personal), the first line isn't aligned to the second and there's not enough padding (IIRC the e-default is 12px).

[Mario Guerriero (mefrio-g)]

I just pushed a commit where I substituted the use of the SaveDialog with the SaveOnCloseDialog. It looks "better" and has the layout which was decided by the designers

[Andrea Basso (voluntatefaber)]

Another thing: we should use "Close without saving" instead of "Discard", it's clearer.

[Andrea Basso (voluntatefaber)]

Ok, just one more thing (btw, last comment was made before I saw you answer): why does it use "from the last 4 seconds"?

[Mario Guerriero (mefrio-g)]

It was decided by the designers who wanted to follow the gedit's one,
http://people.gnome.org/~paolo/screenshots/close-dialog/close-single.png

[Danielle Foré (danrabbit)]

I'd be interested to see how it looks with "close without saving". If the string isn't too long, it is much clearer.

I'm +/- 0 to the "last n seconds" thing if we decided we didn't like it.

[Andrea Basso (voluntatefaber)]

Dan: I think he was talking about the "last n seconds" thing, after last changes Scratch uses "Close without saving".

Mario: ok, but then why is it hardcoded?