[FFe] Please include libarchive 3.0.3-6 from Debian unstable

[Savvas Radevic]

Currently Ubuntu 12.04 has libarchive v2.8.5. There is a new upstream version of libarchive.

Main Goal: also include/build ligxps 0.2.1 and allow users to open .xps[1] files using evince.

Notes:
* The current version of libarchive (2.8.5) allows us to build/use libgxps and enable xps in evince. However, it will not work with xps files created by Microsoft XPS Document Writer (a "virtual printer"). [2] - FIXED (libarchive >= 3.0.0)
* We need debian package libarchive version 3.0.3-6 because of another problem with xps files [3] - FIXED (debian package libarchive12 version >= 3.0.3-6)
* I have a working PPA set up on launchpad: libarchive 3.0.3-6 (patched 3.0.3-5) + libgxps 0.2.1 + xps-enabled evince - https://launchpad.net/~medigeek/+archive/evince-xps/
* If Ubuntu official packages are built using the same infrastructure/software (i.e. build daemons) as Launchpad PPA, then one more patch is required on top of libarchive 3.0.3-6 [4]

Testing dependencies:
* As I was informed there are about a dozen packages that depend on libarchive and will have to be rebuilt if we include a new upstream release. Rebuilt checked: https://launchpad.net/~medigeek/+archive/libarchive-experimental/+packages - 1 package failed out of 14 in total (see comment #7).

[1] .xps: OpenXPS or XPS stands for XML Paper Specification. It is based on XML and it's a new electronic paper format originally developed by Microsoft and it serves as a PDF alternative. XPS files are usually created using "Microsoft XPS Document Writer" in Windows environments. It is now standardized as an open standard document format.
[2] https://bugzilla.gnome.org/show_bug.cgi?id=670895
[3] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=662603
[4] https://bugs.launchpad.net/launchpad/+bug/942994 - patch: https://gist.github.com/2008578

[Savvas Radevic (medigeek)]

TEST CASE: See example_and_dpkg_-i.log
Used bsdtar as an example to show that:
* libarchive 2.8.5 cannot handle and uncompress xps files correctly, whereas libarchive 3.0.3 can.
* successful installation of all files using dpkg and apt-get -f install to fix dependencies.

[Savvas Radevic (medigeek)]

xps files used as examples

[Savvas Radevic (medigeek)]

Screenshot to show a working example of evince (with enabled xps)

[Savvas Radevic (medigeek)]

Upstream changelog and NEWS.
ChangeLog is pasted from release notes: https://github.com/libarchive/libarchive/wiki/ReleaseNotes

[Savvas Radevic (medigeek)]

pbuilder precise log file

[Savvas Radevic (medigeek)]

I've set up a test ppa to check whether packages fail or build:
https://launchpad.net/~medigeek/+archive/libarchive-experimental/+packages

At the moment, 3 packages failed. I should've waited for cmake-data (i386) to be built first, but I uploaded all of the packages. 2 failed for this reason and I'll try the build tomorrow.

However 1 failed with this error: /build/buildd/gmameui-0.2.12/src/gmameui-zip-utils.c:94: undefined reference to `archive_read_data_into_buffer' - that was expected, provided that the gmameui has not seen a new version since 2009: http://gmameui.sourceforge.net/
There's an easy fix for this one: (https://aur.archlinux.org/packages/gm/gmameui/PKGBUILD)
"
    # archive_read_data_into_buffer() is deprecated in libarchive
    /bin/sed -i 's/archive_read_data_into_buffer/archive_read_data/' src/gmameui-zip-utils.c
"

There is some documentation to patch the packages to use the new format: https://github.com/libarchive/libarchive/wiki/Libarchive3 - I sure hope that none of the other packages fail.

[Savvas Radevic (medigeek)]

Result: Build test succeeded for all packages that depend on libarchive-dev, except for gmameui (which did not have an upstream release since 2009 - http://gmameui.sourceforge.net/ ).

https://launchpad.net/~medigeek/+archive/libarchive-experimental/+packages
https://launchpad.net/~medigeek/+archive/libarchive-experimental/+sourcepub/2298858/+listing-archive-extra

gmameui requires a trivial single-line patch: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=653231

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Scott Kitterman (kitterman)]

How much testing of the rebuilt packages did you do?

[Savvas Radevic (medigeek)]

None yet. I'll try some today and let you know!

[Savvas Radevic (medigeek)]

Tested ark, gvfsd-archive, pkcon (packagekit) and hydrogen (not sure about this one, I tested playback/save/open project files).
Are these enough?

[Martin Pitt (pitti)]

Thanks for testing! This sounds quite fine, please let's get that in before beta-2 then.

[Martin Pitt (pitti)]

Synced 3.0.3-5 from Debian testing.

I just noticed that you requested -6, and indeed that has a nice bug fix. I'll sponsor that once -5 is published (otherwise the changelog will look bad).

[Martin Pitt (pitti)]

Synced:

libarchive (3.0.3-6) unstable; urgency=low

  * Add patch to fix infinite loop in xps files (Closes: #662603)
    - Thanks for the patch to Savvas Radevic!

 -- Andreas Henriksson <email address hidden> Mon, 05 Mar 2012 16:23:05 +0100

[Savvas Radevic (medigeek)]

FTBFS on i386 build:
https://launchpad.net/ubuntu/+source/libarchive/3.0.3-6/+build/3290141
https://launchpadlibrarian.net/96904777/buildlog_ubuntu-precise-i386.libarchive_3.0.3-6_FAILEDTOBUILD.txt.gz
It looks like it needs the patch that I mentioned in [4] above. Should I file a new bug?
I've attached the patch.

[Martin Pitt (pitti)]

No need for a new bug, we already have bug 942994. Thanks! I'll sponsor this now.

[Savvas Radevic (medigeek)]

One more question: Do we have to order a new rebuild for all packages that build-depend on libarchive or not?

[Jeremy Bícha (jbicha)]

Yes, anything that shows under libarchive1 at http://people.canonical.com/~ubuntu-archive/nbs.html

[Martin Pitt (pitti)]

Savvas Radevic [2012-03-16 15:04 -0000]:
> One more question: Do we have to order a new rebuild for all packages
> that build-depend on libarchive or not?

Yes, we do. I already did most of them today.
http://people.canonical.com/~ubuntu-archive/nbs.html shows the
progress and remaining packages.

Martin
--
Martin Pitt | http://www.piware.de
Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org)

[Savvas Radevic (medigeek)]

Just a reminder for gmameui, there's an easy fix to make it work in comment #6
Here's the debdiff patch (with quilt patch). I'll post a pbuilder buildlog soon.

[Savvas Radevic (medigeek)]

The buildlog, along with debc and lintian output.

[Martin Pitt (pitti)]

Thanks Savvas! Sponsoring now.