Battery Indicator is black on the panel

[Danielle Foré]

Battery indicator in the panel is black instead of white.

[xapantu (xapantu)]

This is not a problem with the icons?

[Danielle Foré (danrabbit)]

No, they are -symbolic icons.

I've proposed a branch merge that fixes the issue.

[Victor Martinez (victored)]

Daniel, I think that this should not be fixed in Wingpanel.

Setting the foreground color in Wingpanel's stylesheet is equivalent to hardcoding them inside the application, breaking compatibility with other themes (light text and icons under Radiance, for instance).

Now that we have symbolic icons, it will be theme's fault if they have not the same foreground color as the text.

[Danielle Foré (danrabbit)]

But we do ship a default theme with wingpanel that sets the text color already. The merge I've proposed just adds GtkImage to the list of classes.

There is absolutely no code whatsoever in any theme that deals with wingpanel. If you think we should move this theming into eGTK and no longer supply a theme that's fine, but that means we need to add the class names to wingpanel so that this is possible. And it guarantees breakage in other themes because no other theme cares about wingpanel at all.

Ambiance and Radiance will never be a perfect fit for Pantheon because they are Unity themes. That is just the reality of it.

[Sergey "Shnatsel" Davidoff (shnatsel)]

Ambiance works perfectly with Wingpanel here. Screenie attached.

[Victor Martinez (victored)]

Daniel, I agree with you. There are some facts to take into consideration though:

1) Most themes (Ambiance and Radiance included) provide styling for the "gnome-panel-menu-bar" class. It is not taking effect in Wingpanel because the default style is loaded with a very high priority (600, equivalent to GTK_STYLE_PROVIDER_PRIORITY_APPLICATION), making it impossible to override the style from the user's theme.

2) Wingpanel also uses the "menubar" class, and since there's no style information regarding that class in the default style sheet, it can be overriden. That's why the panel looks like a menubar in Sergey's screenshot. The foreground color still follows the default style.

In conclusion, we need to fix the priority issue described in (1) and remove the style class mentioned in (2). If we do that, it's fine if we leave the foreground color in the stylesheet.

[Sergey "Shnatsel" Davidoff (shnatsel)]

The text in Wingpanel's menus is unreadable in Ambiance now.

[Sergey "Shnatsel" Davidoff (shnatsel)]

(it's still white in Unity, so it doesn't look like a theming issue. Also, I can't guarantee it's caused by the change described in this bug)