belongsTo should validate tenant name not id

Bug #949648 reported by Michael Basnight
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Undecided
Michael Basnight

Bug Description

the spec is very vague on this, but token validation in openstack common and nova use the tenant name as the "project". Also rackspace uses the tenant name currently in production for belongsTo. I propose to check the name instead of the id for these reasons.

Changed in keystone:
assignee: nobody → Michael Basnight (hubcap)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/5062

Revision history for this message
Joseph Heck (heckj) wrote :

seems like a bad idea going forward to match belongsTo (on behalf of... tokens) to a name and not the ID.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/5062
Committed: http://github.com/openstack/keystone/commit/5c6bccf1c57b06a19845c696c19274ae9f080104
Submitter: Jenkins
Branch: master

commit 5c6bccf1c57b06a19845c696c19274ae9f080104
Author: Michael Basnight <email address hidden>
Date: Wed Mar 7 22:32:23 2012 -0600

    fixes lp#949648 change belongsTo validate to name

    Change-Id: I3d36290ad95a0440c006e2daff5b831be62957ae

Changed in keystone:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/5571

Changed in keystone:
assignee: Michael Basnight (hubcap) → Dolph Mathews (dolph)
status: Fix Committed → In Progress
Revision history for this message
Dolph Mathews (dolph) wrote :
Changed in keystone:
status: In Progress → Fix Committed
assignee: Dolph Mathews (dolph) → Michael Basnight (hubcap)
Thierry Carrez (ttx)
Changed in keystone:
milestone: none → essex-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: essex-rc1 → 2012.1
Revision history for this message
Mark Miller (mark-m-miller) wrote :

I am wondering why you don't simply add provisions for both the tenant ID and the tenant name. Change "belongsTo" to "belongsToId" and add "belongsToName"?

Revision history for this message
Michael Basnight (hubcap) wrote :

Well thats a question for the next version of the spec. This was already in the existing spec and had to be fixed. :D

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.