Scripts should not refer to os.environ["CHECKBOX_SHARE"] to run standalone
Bug #949435 reported by
Marc Tardif
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Checkbox |
Fix Released
|
Low
|
Jeff Lane | ||
Bug Description
The scripts xrandr_cycle and gpu_test refer to the CHECKBOX_SHARE environment variable for the path to the data directory. The problem is that this makes them hard to run standalone from the command line by forcing the user to set the environment accordingly. Instead, the scripts should use the path to themselves to determine the relative path to the data directory which will always be in ../data in the source and when installed.
Related branches
lp:~bladernr/checkbox/949435-remove-hard-coded-paths
- Javier Collado (community): Approve
-
Diff: 102 lines (+21/-7)5 files modifieddebian/changelog (+9/-0)
jobs/graphics.txt.in (+1/-1)
jobs/suspend.txt.in (+2/-2)
scripts/gpu_test (+2/-1)
scripts/xrandr_cycle (+7/-3)
Revision history for this message
| Jeff Lane (bladernr) wrote | #1 |
| Changed in checkbox: | |
| status: | New → Confirmed |
| importance: | Undecided → Low |
| Changed in checkbox: | |
| assignee: | nobody → Jeff Lane (bladernr) |
| status: | Confirmed → In Progress |
| Changed in checkbox: | |
| status: | In Progress → Fix Committed |
| Changed in checkbox: | |
| milestone: | none → 0.13.5 |
| Changed in checkbox: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Yes indeed... scripts that wont work stand-alone really annoy me :/