The 2F Auth device management interface is unsightly
Bug #948408 reported by
Julien Funk
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Canonical SSO provider |
Fix Released
|
High
|
Stuart Metcalfe | ||
Bug Description
I've attached a screenshot with the details of what's wrong with this page, see notes below:
1) Success message is misaligned and the icon has a different background color than the site itself
2) The text 'Require an authentication device' overlaps the radio buttons
3) 'Rename' & 'Delete' buttons to manage existing devices should be smaller, and for some reason they are stacking on top of each other looking very ugly - isntead, they should be on the same line, one after the other
Related branches
lp:~stuartmetcalfe/canonical-identity-provider/more-2f-fixes
- Simon Davy (community): Approve
-
Diff: 349 lines (+104/-31)14 files modifiedidentityprovider/media/ubuntu/forms.css (+1/-1)
identityprovider/media/ubuntu/styles.css (+27/-1)
identityprovider/templates/account/applications.html (+3/-3)
identityprovider/templates/account/delete_email.html (+4/-4)
identityprovider/templates/account/emails.html (+3/-3)
identityprovider/templates/device/list.html (+5/-5)
identityprovider/templates/launchpad/registration/twofactor.html (+2/-2)
identityprovider/templates/ubuntu/registration/twofactor.html (+2/-2)
identityprovider/templates/widgets/ubuntu/logout-button.html (+10/-2)
identityprovider/tests/acceptance/applications/delete_app.py (+2/-2)
identityprovider/tests/acceptance/logout/logout_deep_pages.py (+36/-0)
identityprovider/tests/acceptance/shared/helpers.py (+2/-2)
identityprovider/views/account.py (+1/-1)
identityprovider/views/ui.py (+6/-3)
Revision history for this message
| Julien Funk (jaboing) wrote | #1 |
| Changed in canonical-identity-provider: | |
| status: | New → Confirmed |
| assignee: | nobody → Stuart Metcalfe (stuartmetcalfe) |
Revision history for this message
| Stuart Metcalfe (stuartmetcalfe) wrote | #2 |
| Changed in canonical-identity-provider: | |
| milestone: | none → 2-factor-internal-rollout |
Revision history for this message
| Stuart Metcalfe (stuartmetcalfe) wrote | #3 |
| Changed in canonical-identity-provider: | |
| status: | Confirmed → In Progress |
| Changed in canonical-identity-provider: | |
| status: | In Progress → Fix Committed |
| Changed in canonical-identity-provider: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
> 1) Success message [...] icon has a different background color than the site itself
This is a known issue - see bug #854854