TPAC regression: searchbox no longer gets autofocus

Bug #946873 reported by Dan Scott
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Low
Unassigned

Bug Description

* Evergreen master

With the merging of autosuggest functionality, the overhaul of the search input box from a plain old INPUT element into a Dijit introduced a small regression: the searchbox lost autofocus. A small tragedy.

With user/dbs/restore_searchbox_focus in the working repo, we can reclaim autofocus without too much hackery. It's a small matter of an addOnLoad() call for the Dojo case, and adding the HTML5 "autofocus" attribute in the non-Dojo case. The latter won't work on Internet Explorer, so there's some room for doing browser detection and other Modernizr-like jiggery-pokery for the non-Dojo case, but then there wouldn't be much point of avoiding Dojo. So... let's keep the non-Dojo case as simple as possible.

Tags: pullrequest
Revision history for this message
Mike Rylander (mrylander) wrote :

Picked into master, hurrah!

Changed in evergreen:
status: New → Fix Committed
Changed in evergreen:
milestone: 2.2.0alpha2 → 2.2.0alpha3
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.