pt-query-digest should print a better message when an unsupported log format is specified
Bug #946438 reported by
Fernando Ipar
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Percona Toolkit moved to https://jira.percona.com/projects/PT |
Fix Released
|
Medium
|
Baron Schwartz |
Bug Description
Right now pt-query-digest prints a perl error if an unsupported/non existing log type is used:
root@someserver
Failed to load wronglog module: Can't locate object method "new" via package "wronglog" (perhaps you forgot to load "wronglog"?) at ./pt-query-digest line 12346.
I have seen this cause confusion for users when they mistype a log format (i.e. tpcdump) and think the tool should print a more friendly message, perhaps listing the supported types.
Related branches
lp:~percona-toolkit-dev/percona-toolkit/meaningful-type-error-fix-bug-946438
- Daniel Nichter: Approve
-
Diff: 14 lines (+5/-0)1 file modifiedbin/pt-query-digest (+5/-0)
Changed in percona-toolkit: | |
assignee: | nobody → Baron Schwartz (baron-xaprb) |
importance: | Undecided → Medium |
status: | New → Confirmed |
milestone: | none → 2.0.4 |
tags: | added: error-message pt-query-digest |
Changed in percona-toolkit: | |
status: | Confirmed → In Progress |
Changed in percona-toolkit: | |
status: | In Progress → Fix Committed |
Changed in percona-toolkit: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Percona now uses JIRA for bug reports so this bug report is migrated to: https:/ /jira.percona. com/browse/ PT-491