Please add support for the "blacklist-iso3166::" tag

Bug #944670 reported by Michael Vogt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Software Center Agent
Fix Released
Medium
Danny Tamez

Bug Description

Hi,

to support blacklisting certain regions the server should support sending a "blacklist-iso3166::" tag. This will automatically cause the client to skip that app and it will not appear in software-center. This also requires additional work to ensure that in the purchase/download step that region is checked via something like geoip.

Revision history for this message
Anthony Lenton (elachuni) wrote :

Available regions should be all countries from ISO-3166.
We're going to use the 2-letter codes, so for example "blacklist-iso3166::us" would make an app unavailable for purchase in the US.

The developer should be able to select which regions are blacklisted. Probably the same screen where hardware requirements are selected would make sense for this.

It might be interesting to restrict the number of blacklisted countries to something reasonable like 100 countries, so that you can't select a huge number of debtags for your app

Also consider bug #1006570 when you implement this.

Changed in software-center-agent:
status: New → Confirmed
importance: Undecided → Medium
Danny Tamez (zematynnad)
Changed in software-center-agent:
assignee: nobody → Danny Tamez (zematynnad)
status: Confirmed → In Progress
Revision history for this message
Danny Tamez (zematynnad) wrote :

Some discussion on the FK thing:

[Friday, June 01, 2012] [01:28:46 PM] <zematynnad> hey Anthony - I'm trying to understand why the debtags_id is used in application instead of just a FK to debtags, any ideas?
[Friday, June 01, 2012] [01:29:06 PM] <achuni> performance
[Friday, June 01, 2012] [01:29:14 PM] <zematynnad> I see
[Friday, June 01, 2012] [01:29:19 PM] <achuni> so that it doesn't need to perform a separate query each time it wants the debtags
[Friday, June 01, 2012] [01:29:24 PM] <achuni> into a many-to-many table
[Friday, June 01, 2012] [01:29:39 PM] <zematynnad> should I follow the same pattern for the blacklist and whitelist fields then?
[Friday, June 01, 2012] [01:30:02 PM] <achuni> so, I'd say yes
[Friday, June 01, 2012] [01:30:13 PM] <achuni> but I'm not entirely sure it's the best idea
[Friday, June 01, 2012] [01:30:39 PM] <achuni> (I'd say yess because I wrote the debtags_id stuff)
[Friday, June 01, 2012] [01:31:02 PM] <achuni> if you don't feel strongly against the idea, then yes

Danny Tamez (zematynnad)
Changed in software-center-agent:
status: In Progress → Fix Committed
Revision history for this message
Danny Tamez (zematynnad) wrote :

davmor2: To check this on sca.razorgirl.info I:
- created an app and tried to add *both* blacklist entries and whitelist entries (was not able to do so)
- added blacklist entries only, saved it and moved it through to published
- went back and changed the blacklist to a whitelist and checked it in the changes pending list
- finally saved the app and checked the values of as_serializable to see that the whitelist entries were indeed sent as debtag entries

Dave Morley (davmor2)
Changed in software-center-agent:
status: Fix Committed → Fix Released
Dave Morley (davmor2)
Changed in software-center-agent:
milestone: none → 12.07
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.