Adding only one floating IP to the cloud

[Édouard Thuleau]

If we try to add only one floating IP (subnet /32) to the cloud with 'nova-mabage' command, nothing appends.

The 'nova-manage' command uses 'netaddr' python library with class 'IPNetwork' which exclude the network and broadcast addresses. So the floating IP '80.0.0.1/32' for example, is exclude and not added to the floating IP list (without warning or errors).

[Édouard Thuleau (ethuleau)]

diff --git a/bin/nova-manage b/bin/nova-manage
index 08c4133..45f23e2 100755
--- a/bin/nova-manage
+++ b/bin/nova-manage
@@ -702,6 +702,12 @@ class FloatingIpCommands(object):
             pool = FLAGS.default_floating_pool
         if not interface:
             interface = FLAGS.public_interface
+ if addresses.size == 1:
+ db.floating_ip_create(admin_context,
+ {'address': str(addresses.ip),
+ 'pool': pool,
+ 'interface': interface})
+ return
         for address in addresses.iter_hosts():
             db.floating_ip_create(admin_context,
                                   {'address': str(address),
@@ -711,7 +717,12 @@ class FloatingIpCommands(object):
     @args('--ip_range', dest="ip_range", metavar='<range>', help='IP range')
     def delete(self, ip_range):
         """Deletes floating ips by range"""
- for address in netaddr.IPNetwork(ip_range).iter_hosts():
+ addresses = netaddr.IPNetwork(ip_range)
+ if addresses.size == 1:
+ db.floating_ip_destroy(context.get_admin_context(),
+ str(addresses.ip))
+ return
+ for address in addresses.iter_hosts():
             db.floating_ip_destroy(context.get_admin_context(),
                                    str(address))

[Mike Scherbakov (mihgen)]

Fix committed to the master. See commit sha e430c8424a62d9d397980899ae0458a5e947704e